Update feature list

third_party/WebKit/public/platform/WebFeaturePolicy.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebFeaturePolicy_h
 #define WebFeaturePolicy_h
 
 #include "WebCommon.h"
 #include "WebSecurityOrigin.h"
 #include "WebString.h"
 #include "WebVector.h"
 
 namespace blink {
 
 // These values map to the features which can be controlled by Feature Policy.
 // TODO(iclelland): Link to the spec where the behaviour for each of these is

[Rick Byers, 2017/03/27 21:19:46]

nit: can you remove the TODO now?

 // defined.
+//
+// Below are the features currently defined in the spec:
+// https://wicg.github.io/feature-policy/#defined-features
+//    Camera
+//    Eme
+//    Fullscreen
+//    Geolocation
+//    Microphone
+//    Midi
+//    Payment
+//    Speaker
+//    Vibrate
+// Below are the features currently implemented in Blink:

[Rick Byers, 2017/03/27 21:19:46]

I was initially confused by this (if the others aren't implemented in blink, why
mention them at all?).  But now I see the "feature policy experimental features"
flag.

Maybe change this whole section just to say something like:

"Features are defined in
https://wicg.github.io/feature-policy/#defined-features.  Many of these are
still under development
in blink behind the featurePolicyExperimentalFeatures flag, see
getWebFeaturePolicyFeature()."

Then you don't have to worry about keeping the comment here in-sync with the
code in getWebFeaturePolicyFeature.

But if you want to explicitly list the 3 that are ready, that's fine with me too
(I can see the argument for it).  I just wouldn't bother listing out the rest
since it's redundant with the list below.

+//    Fullscreen
+//    Payment
+//    Vibrate
 enum class WebFeaturePolicyFeature {
   NotFound = 0,
+  // Controls access to video input devices.
+  Camera,
+  // Controls whether navigator.requestMediaKeySystemAccess is allowed.
+  Eme,
+  // Controls whether Element.requestFullscreen is allowed.
+  Fullscreen,
+  // Controls access to Geolocation interface.
+  Geolocation,
+  // Controls access to audio input devices.
+  Microphone,
+  // Controls access to requestMIDIAccess method.
+  MidiFeature,
+  // Controls access to PaymentRequest interface.
+  Payment,
+  // Controls access to audio output devices.
+  Speaker,
+  // Controls access to navigator.vibrate method.
+  Vibrate,
   // Controls access to document.cookie attribute.
   DocumentCookie,
   // Contols access to document.domain attribute.
   DocumentDomain,
   // Controls access to document.write and document.writeln methods.
   DocumentWrite,
-  // Controls whether Element.requestFullscreen is allowed.
-  Fullscreen,
-  // Controls access to Geolocation interface.
-  Geolocation,
-  // Controls access to requestMIDIAccess method.
-  MidiFeature,
   // Controls access to Notification interface.
   Notifications,
-  // Controls access to PaymentRequest interface.
-  Payment,
   // Controls access to PushManager interface.
   Push,
   // Controls whether synchronous script elements will run.
   SyncScript,
   // Controls use of synchronous XMLHTTPRequest API.
   SyncXHR,
-  // Controls access to NavigatorUserMedia interface.
-  Usermedia,
-  // Controls access to navigator.vibrate method.
-  Vibrate,
   // Controls access to RTCPeerConnection interface.
   WebRTC,
   LAST_FEATURE = WebRTC
 };
 
 struct BLINK_PLATFORM_EXPORT WebParsedFeaturePolicyDeclaration {
   WebParsedFeaturePolicyDeclaration() : matchesAllOrigins(false) {}
   WebFeaturePolicyFeature feature;
   bool matchesAllOrigins;
   WebVector<WebSecurityOrigin> origins;
@@ skipping 10 matching lines @@
   virtual ~WebFeaturePolicy() {}
 
   // Returns whether or not the given feature is enabled for the origin of the
   // document that owns the policy.
   virtual bool IsFeatureEnabled(blink::WebFeaturePolicyFeature) const = 0;
 };
 
 }  // namespace blink
 
 #endif  // WebFeaturePolicy_h