base/trace_event/memory_dump_manager.h - Issue 2766173003: memory-infra: Fill the memory dump callback result (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_manager.h

Issue 2766173003: memory-infra: Fill the memory dump callback result (2/2) (Closed)

Patch Set: rebase for struct change Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/memory_dump_manager.h

diff --git a/base/trace_event/memory_dump_manager.h b/base/trace_event/memory_dump_manager.h

index 3303baab0fd37452db92a951a6bb904a7cadb446..d4fdf8aa1f5cb61e6bf7f9f1e461f7aae435dd8b 100644

--- a/base/trace_event/memory_dump_manager.h

+++ b/base/trace_event/memory_dump_manager.h

@@ -299,6 +299,9 @@ class BASE_EXPORT MemoryDumpManager : public TraceLog::EnabledStateObserver {

static void SetInstanceForTesting(MemoryDumpManager* instance);

static uint32_t GetDumpsSumKb(const std::string&, const ProcessMemoryDump*);

+ static void FillOsDumpFromProcessMemoryDump(

+ MemoryDumpCallbackResult::OSMemDump&,

+ ProcessMemoryDump*);

static void FinalizeDumpAndAddToTrace(

std::unique_ptr<ProcessMemoryDumpAsyncState> pmd_async_state);