Issue 276613007: Refactor V8StringResource::prepare

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276613007: Refactor V8StringResource::prepare (Closed)

Created:
6 years, 7 months ago by yhirano

Modified:
6 years, 7 months ago

Reviewers:
haraken

CC:
blink-reviews, Nils Barth (inactive), arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, blink-reviews-bindings_chromium.org, haraken, Nate Chapin

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Refactor V8StringResource::prepare V8StringResource<T>::prepareBase was not a good name. Because V8StringResource<T>::prepare added some additional checks depending on T, I renamed them to "check", added the check to prepareBase and rename it to "prepare". This is a refactoring CL and doesn't change the behavior. BUG=NONE Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173717