chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2766093002: MD Settings: validate home button url input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2766093002: MD Settings: validate home button url input (Closed)

Patch Set: fix formatting Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/settings_input.js ('K') | « chrome/browser/resources/settings/search_engines_page/search_engine_dialog.html ('k') | chrome/test/data/webui/settings/appearance_page_test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 3d4f0a5c35e4c1634a7ad1e1a365cd832c7abd5e..654871d5f1978e0bca0173139d2b7edf7e9c0320 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -97,6 +97,7 @@ void AddCommonStrings(content::WebUIDataSource* html_source, Profile* profile) {

{"settings", IDS_SETTINGS_SETTINGS},

{"toggleOn", IDS_SETTINGS_TOGGLE_ON},

{"toggleOff", IDS_SETTINGS_TOGGLE_OFF},

+ {"notValid", IDS_SETTINGS_NOT_VALID},

};

AddLocalizedStringsBulk(html_source, localized_strings,

arraysize(localized_strings));

@@ -1558,7 +1559,6 @@ void AddSearchEnginesStrings(content::WebUIDataSource* html_source) {

IDS_SETTINGS_SEARCH_ENGINES_ADD_SEARCH_ENGINE},

{"searchEnginesEditSearchEngine",

IDS_SETTINGS_SEARCH_ENGINES_EDIT_SEARCH_ENGINE},

- {"searchEnginesNotValid", IDS_SETTINGS_SEARCH_ENGINES_NOT_VALID},

{"searchEngines", IDS_SETTINGS_SEARCH_ENGINES},

{"searchEnginesDefault", IDS_SETTINGS_SEARCH_ENGINES_DEFAULT_ENGINES},

{"searchEnginesOther", IDS_SETTINGS_SEARCH_ENGINES_OTHER_ENGINES},