Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2844)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 2766093002: MD Settings: validate home button url input (Closed)
Patch Set: adjust blur/enter behaviors Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index f741a59b07b4c642e7488d0fc6ba9e3e1ba31871..c428cff20a06954f309e154ac583a503d62d5090 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -26,8 +26,14 @@
-webkit-margin-start: 12px;
}
+ #custom-input {
+ margin-bottom: 1rem;
+ }
+
#customHomePage {
- width: 200px;
+ --paper-input-container: {
+ width: 200px;
+ };
}
</style>
<settings-animated-pages id="pages" section="appearance">
@@ -113,7 +119,7 @@
label="$i18n{homePageNtp}" no-extension-indicator>
</controlled-radio-button>
<controlled-radio-button class="list-item" name="false"
- pref="[[prefs.homepage_is_newtabpage]]"
+ pref="[[prefs.homepage_is_newtabpage]]" id="custom-input"
no-extension-indicator>
<!-- TODO(dbeam): this can show double indicators when both
homepage and whether to use the NTP as the homepage are
@@ -122,7 +128,9 @@
no-label-float pref="{{prefs.homepage}}"
label="$i18n{enterCustomWebAddress}"
can-tab="[[!prefs.homepage_is_newtabpage.value]]"
- stop-keyboard-event-propagation no-extension-indicator>
+ stop-keyboard-event-propagation no-extension-indicator
+ error-message="$i18n{homeUrlNotValid}"
+ on-input="validate_">
</settings-input>
</controlled-radio-button>
<template is="dom-if" if="[[prefs.homepage.extensionId]]">

Powered by Google App Engine
This is Rietveld 408576698