chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc - Issue 2766093002: MD Settings: validate home button url input

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Issue 2766093002: MD Settings: validate home button url input (Closed)

Patch Set: Merge branch 'master' into home-button Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/settings_input.js ('K') | « chrome/browser/resources/settings/controls/settings_input.js ('k') | chrome/test/data/webui/settings/appearance_page_test.js » ('j') | chrome/test/data/webui/settings/appearance_page_test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

diff --git a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

index 3d4f0a5c35e4c1634a7ad1e1a365cd832c7abd5e..a5ed01fd9a151c39834eecb5cc0176124917cd48 100644

--- a/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

+++ b/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

@@ -307,6 +307,7 @@ void AddAppearanceStrings(content::WebUIDataSource* html_source,

{"customWebAddress", IDS_SETTINGS_CUSTOM_WEB_ADDRESS},

{"enterCustomWebAddress", IDS_SETTINGS_ENTER_CUSTOM_WEB_ADDRESS},

{"homeButtonDisabled", IDS_SETTINGS_HOME_BUTTON_DISABLED},

+ {"homeUrlNotValid", IDS_SETTINGS_HOME_URL_NOT_VALID},

{"themes", IDS_SETTINGS_THEMES},

#if defined(OS_LINUX) && !defined(OS_CHROMEOS)

{"systemTheme", IDS_SETTINGS_SYSTEM_THEME},