Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4940)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js

Issue 2766093002: MD Settings: validate home button url input (Closed)
Patch Set: Merge branch 'master' into home-button Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js b/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
index b139a7f1494d8067d4e5b4245034d6308fa28ff1..034e642c0d50585f69509ddbd5f8eb5e4636cd52 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js
@@ -19,15 +19,21 @@ cr.define('settings', function() {
/** @return {boolean} Whether the current profile is supervised. */
isSupervised: assertNotReached,
-// <if expr="chromeos">
+ // <if expr="chromeos">
openWallpaperManager: assertNotReached,
-// </if>
+ // </if>
useDefaultTheme: assertNotReached,
-// <if expr="is_linux and not chromeos">
+ // <if expr="is_linux and not chromeos">
useSystemTheme: assertNotReached,
-// </if>
+ // </if>
+
+ /**
+ * @param {string} url The url of which to check validity.
+ * @return {!Promise<boolean>}
+ */
+ validateStartupPage: assertNotReached
dpapad 2017/03/24 21:47:43 Nit (optional): It's OK to add a trailing comma he
scottchen 2017/03/24 22:56:31 Done.
};
/**
@@ -58,24 +64,29 @@ cr.define('settings', function() {
return loadTimeData.getBoolean('isSupervised');
},
-// <if expr="chromeos">
+ // <if expr="chromeos">
/** @override */
openWallpaperManager: function() {
chrome.send('openWallpaperManager');
},
-// </if>
+ // </if>
/** @override */
useDefaultTheme: function() {
chrome.send('useDefaultTheme');
},
-// <if expr="is_linux and not chromeos">
+ // <if expr="is_linux and not chromeos">
/** @override */
useSystemTheme: function() {
chrome.send('useSystemTheme');
},
-// </if>
+ // </if>
+
+ /** @override */
+ validateStartupPage: function(url) {
+ return cr.sendWithPromise('validateStartupPage', url);
+ },
};
return {

Powered by Google App Engine
This is Rietveld 408576698