MD Settings: validate home button url input

chrome/browser/resources/settings/appearance_page/appearance_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('settings', function() {
   /** @interface */
   function AppearanceBrowserProxy() {}
 
   AppearanceBrowserProxy.prototype = {
     /** @return {!Promise<number>} */
@@ skipping 40 matching lines @@
       return new Promise(function(resolve) {
         chrome.management.get(themeId, resolve);
       });
     },
 
     /** @override */
     isSupervised: function() {
       return loadTimeData.getBoolean('isSupervised');
     },
 
-// <if expr="chromeos">
+    // <if expr="chromeos">

[dpapad, 2017/03/24 01:39:31]

+dbeam:
clang-format is causing those <if expr> statements to be indented. 
Is that intentional or should we revert those changes? They are causing
unnecessarily larger diffs.

[scottchen, 2017/03/24 20:48:54]

Yeah I'm wondering the same thing too. I thought we originally gave these 0
indentation so that they're easier to spot. Maybe we should modify clang-format
rule to not indent \^// <.*\

[dpapad, 2017/03/24 21:47:43]

Since dbeam is OOO, can we revert those changes for now, until we establish
whether the current output o the formatting tool is what we really want?

[scottchen, 2017/03/24 22:56:30]

Done.

     /** @override */
     openWallpaperManager: function() {
       chrome.send('openWallpaperManager');
     },
-// </if>
+    // </if>
 
     /** @override */
     useDefaultTheme: function() {
       chrome.send('useDefaultTheme');
     },
 
-// <if expr="is_linux and not chromeos">
+    // <if expr="is_linux and not chromeos">
     /** @override */
     useSystemTheme: function() {
       chrome.send('useSystemTheme');
     },
-// </if>
+    // </if>
+
+    /** @override */
+    validateStartupPage: function(url) {

[dpapad, 2017/03/24 01:39:31]

This method needs to be declared on the AppearanceBrowserProxy interface at the
top of this file. Otherwise there is nothing to "override" here.

[scottchen, 2017/03/24 20:48:54]

Done.

+      return cr.sendWithPromise('validateStartupPage', url);
+    },
   };
 
   return {
     AppearanceBrowserProxy: AppearanceBrowserProxy,
     AppearanceBrowserProxyImpl: AppearanceBrowserProxyImpl,
   };
 });