MD Settings: validate home button url input

chrome/browser/resources/settings/appearance_page/appearance_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * 'settings-appearance-page' is the settings page containing appearance
  * settings.
  *
  * Example:
  *
@@ skipping 34 matching lines @@
         return [
           {value: 9, name: loadTimeData.getString('verySmall')},
           {value: 12, name: loadTimeData.getString('small')},
           {value: 16, name: loadTimeData.getString('medium')},
           {value: 20, name: loadTimeData.getString('large')},
           {value: 24, name: loadTimeData.getString('veryLarge')},
         ];
       },
     },
 
+    /** @private */
+    isHomeUrlInvalid_: Boolean,
+
     /**
      * List of options for the page zoom drop-down menu.
      * @type {!Array<number>}
      */
     pageZoomLevels_: {
       readOnly: true,
       type: Array,
       value: [
         // TODO(dbeam): get these dynamically from C++ instead.
         1 / 4,
@@ skipping 86 matching lines @@
   /** @private */
   onDisableExtension_: function() {
     this.fire('refresh-pref', 'homepage');
   },
 
   /** @private */
   onThemesTap_: function() {
     window.open(this.themeUrl_ || loadTimeData.getString('themesGalleryUrl'));
   },
 
-// <if expr="chromeos">
+  // <if expr="chromeos">
   /**
    * ChromeOS only.
    * @private
    */
   openWallpaperManager_: function() {
     this.browserProxy_.openWallpaperManager();
   },
-// </if>
+  // </if>
 
   /** @private */
   onUseDefaultTap_: function() {
     this.browserProxy_.useDefaultTheme();
   },
 
-// <if expr="is_linux and not chromeos">
+  // <if expr="is_linux and not chromeos">
   /**
    * @param {boolean} useSystemTheme
    * @private
    */
   useSystemThemePrefChanged_: function(useSystemTheme) {
     this.useSystemTheme_ = useSystemTheme;
   },
 
   /**
    * @param {string} themeId
@@ skipping 24 matching lines @@
    */
   showThemesSecondary_: function(themeId, useSystemTheme) {
     return this.showUseClassic_(themeId, useSystemTheme) ||
            this.showUseSystem_(themeId, useSystemTheme);
   },
 
   /** @private */
   onUseSystemTap_: function() {
     this.browserProxy_.useSystemTheme();
   },
-// </if>
+  // </if>
 
   /**
    * @param {string} themeId
    * @param {boolean} useSystemTheme
    * @private
    */
   themeChanged_: function(themeId, useSystemTheme) {
     if (themeId) {
       assert(!useSystemTheme);
 
@@ skipping 33 matching lines @@
   /**
    * @see content::ZoomValuesEqual().
    * @param {number} zoom1
    * @param {number} zoom2
    * @return {boolean}
    * @private
    */
   zoomValuesEqual_: function(zoom1, zoom2) {
     return Math.abs(zoom1 - zoom2) <= 0.001;
   },
+
+  /**
+   * @param {!Event} event
+   * @private
+   */
+  validate_: function(event) {
+    var inputElement = Polymer.dom(event).localTarget;
+
+    if (inputElement.value == '') {

[Dan Beam, 2017/03/27 11:43:07]

why handle this special case differently?

[scottchen, 2017/03/28 21:02:20]

Same behavior as on-startup page setup currently - we don't want the input to
say "Not Valid" when the user had just chosen this option and haven't typed in
anything yet.

+      this.isHomeUrlInvalid_ = false;
+      return;
+    }
+
+    this.browserProxy_.validateStartupPage(inputElement.value)
+        .then(function(isValid) {
+          this.isHomeUrlInvalid_ = !isValid;
+        }.bind(this));
+  },
 });