MD Settings: validate home button url input

chrome/test/data/webui/settings/appearance_page_test.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @implements {settings.AppearanceBrowserProxy}
  * @extends {settings.TestBrowserProxy}
  */
 var TestAppearanceBrowserProxy = function() {
   settings.TestBrowserProxy.call(this, [
     'getDefaultZoom',
     'getThemeInfo',
     'isSupervised',
     'openWallpaperManager',
     'useDefaultTheme',
     'useSystemTheme',
+    'validateStartupPage',
   ]);
 
   /** @private */
   this.defaultZoom_ = 1;
 
   /** @private */
   this.isSupervised_ = false;
 };
 
 TestAppearanceBrowserProxy.prototype = {
@@ skipping 25 matching lines @@
   /** @override */
   useDefaultTheme: function() {
     this.methodCalled('useDefaultTheme');
   },
 
   /** @override */
   useSystemTheme: function() {
     this.methodCalled('useSystemTheme');
   },
 
+  /** @override */
+  useSystemTheme: function() {

[dpapad, 2017/03/24 21:47:43]

Accidental copy paste?

[scottchen, 2017/03/24 22:56:31]

Done.

+    this.methodCalled('useSystemTheme');
+  },
+
   /** @param {number} defaultZoom */
   setDefaultZoom: function(defaultZoom) {
     this.defaultZoom_ = defaultZoom;
   },
 
   /** @param {boolean} Whether the user is supervised */
   setIsSupervised: function(isSupervised) {
     this.isSupervised_ = isSupervised;
   },
+
+  /** @override */
+  validateStartupPage: function(value) {
+    this.methodCalled('validateStartupPage');
+    // 'false' is an invalid value for testing purposes.
+    var returnValue = 'false' ? false : true;  // 'false'

[dpapad, 2017/03/24 21:47:43]

Instead of hardcoding an invalid value, how about you add a method as follows

Set this.isValid_ to true in the constructor. Then do

setValidateStartPageResponse(isValid) {
  this.isValid_ = isValid;
}

validateStartupPage(value) {
  this.methodCalled('validateStartupPage', value);
  return Promise.resolve(this.isValid_);
}

From your test, call browserProxy.setValidateStartupPageResponse(false), to
force the validation to fail.

[scottchen, 2017/03/24 22:56:31]

Done.

+    return Promise.resolve(returnValue);
+  },
 };
 
 var appearancePage = null;
 
 /** @type {?TestAppearanceBrowserProxy} */
 var appearanceBrowserProxy = null;
 
 function createAppearancePage() {
   appearanceBrowserProxy.reset();
   PolymerTest.clearBody();
@@ skipping 135 matching lines @@
     }).then(function() {
       assertEquals('110%', getDefaultZoomText());
 
       appearanceBrowserProxy.setDefaultZoom(1.7499999999999);
       createAppearancePage();
       return appearanceBrowserProxy.whenCalled('getDefaultZoom');
     }).then(function() {
       assertEquals('175%', getDefaultZoomText());
     });
   });
+
+  test('show home button toggling', function() {
+    assertFalse(!!appearancePage.$$('.list-frame'));
+    appearancePage.set('prefs', {browser: {show_home_button: {value: true}}});
+
+    Polymer.dom.flush();
+
+    assertTrue(!!appearancePage.$$('.list-frame'));
+  });
+
+  test('home button urls', function() {
+    appearancePage.set('prefs', {
+      browser: {show_home_button: {value: true}},
+      homepage: {type: chrome.settingsPrivate.PrefType.URL, value: 'test'}
+    });
+
+    Polymer.dom.flush();
+
+    var input = appearancePage.$$('#customHomePage');
+    assertTrue(!!input);
+    assertFalse(input.invalid);
+    assertEquals(input.value, 'test');
+
+    input.value = 'false';  // 'false' is an invalid value for testing purposes.
+    input.fire('input');
+
+    return appearanceBrowserProxy.whenCalled('validateStartupPage')
+        .then(function() {
+          Polymer.dom.flush();
+          assertEquals(input.value, 'false');
+          assertTrue(input.invalid);
+
+          // Should reset to default value on change event.
+          input.$$('paper-input').fire('change');

[dpapad, 2017/03/24 21:47:43]

Does the 'change' event have to be fired from paper-input? It seems that the
following would also work', and would avoid accessing settings-input's internal
DOM structure.

input.fire('change');

[scottchen, 2017/03/24 22:56:31]

settingsInput.onChange_ was attached to <paper-input on-change="[[onChange_]]">,
so the change event would have to be triggered on the paper-input element.

+          Polymer.dom.flush();
+          assertEquals(input.value, 'test');
+        });
+  });
 });