Extensions: Keep track of loaded extensions in RendererStartupHelper.

extensions/browser/renderer_startup_helper.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_RENDERER_STARTUP_HELPER_H_
 #define EXTENSIONS_BROWSER_RENDERER_STARTUP_HELPER_H_
 
 #include <map>
 #include <set>
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/memory/singleton.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 #include "components/keyed_service/core/keyed_service.h"
 #include "content/public/browser/notification_observer.h"
 #include "content/public/browser/notification_registrar.h"
 #include "extensions/common/extension_id.h"
 
 namespace content {
 class BrowserContext;
 class RenderProcessHost;
 }
 
 namespace extensions {
 class Extension;
 
+namespace test {
+class RendererStartupHelperTest;
+}  // namespace test
+
 // Informs renderers about extensions-related data (loaded extensions, available
 // functions, etc.) when they start. Sends this information to both extension
 // and non-extension renderers, as the non-extension renderers may have content
 // scripts. Lives on the UI thread. Shared between incognito and non-incognito
 // browser contexts. Also handles sending the loaded, unloaded, and activated
 // extension messages, since these can *only* be sent once the process is
 // initialized.
 // TODO(devlin): "StartupHelper" is no longer sufficient to describe the entire
 // behavior of this class.
 class RendererStartupHelper : public KeyedService,
@@ skipping 14 matching lines @@
                                   content::RenderProcessHost* process);
 
   // Sends a message to all initialized processes to [un]load the given
   // extension. We have explicit calls for these (rather than using an
   // ExtensionRegistryObserver) because this needs to happen before other
   // initialization which might rely on the renderers being notified.
   void OnExtensionUnloaded(const Extension& extension);
   void OnExtensionLoaded(const Extension& extension);
 
  private:
+  friend class test::RendererStartupHelperTest;
+
   // Initializes the specified process, informing it of system state and loaded
   // extensions.
   void InitializeProcess(content::RenderProcessHost* process);
 
   // Untracks the given process.
   void UntrackProcess(content::RenderProcessHost* process);
 
   content::BrowserContext* browser_context_;  // Not owned.
 
   // The set of render processes that have had the initial batch of IPC messages
-  // sent, including the set of loaded extensions. Further messages that
+  // sent, together with the set of loaded extensions. Further messages that
   // activate, load, or unload extensions should not be sent until after this
-  // happens.
-  std::set<content::RenderProcessHost*> initialized_processes_;
+  // happens. Used to keep the track of initialized processes along with its
+  // loaded extensions.
+  std::map<content::RenderProcessHost*, std::set<ExtensionId>>
+      loaded_extensions_;
 
   // The set of ids for extensions that are active in a process that has not
-  // been initialized. The activation message will be sent the process is
-  // initialized.
+  // been initialized. The activation message will be sent once the process is
+  // initialized. This is only valid for uninitialized processes.
   std::map<content::RenderProcessHost*, std::set<ExtensionId>>
       pending_active_extensions_;
 
   content::NotificationRegistrar registrar_;
 
   DISALLOW_COPY_AND_ASSIGN(RendererStartupHelper);
 };
 
 // Factory for RendererStartupHelpers. Declared here because this header is
 // rarely included and it's probably cheaper to put it here than to make the
@@ skipping 16 matching lines @@
   content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const override;
   bool ServiceIsCreatedWithBrowserContext() const override;
 
   DISALLOW_COPY_AND_ASSIGN(RendererStartupHelperFactory);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_RENDERER_STARTUP_HELPER_H_