Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: ios/web/navigation/session_storage_builder.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)
Patch Set: fix unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/session_storage_builder.mm
diff --git a/ios/web/navigation/session_storage_builder.mm b/ios/web/navigation/session_storage_builder.mm
index 6ad68f1f8acfda1e80813b3428376703b04bb6c5..63f420d52c25e874c480044e4caad40e29579b9a 100644
--- a/ios/web/navigation/session_storage_builder.mm
+++ b/ios/web/navigation/session_storage_builder.mm
@@ -20,7 +20,7 @@
// as this functionality moves from CRWSessionController to
// NavigationManagerImpl;
@interface CRWSessionController (ExposedForSerialization)
-@property(nonatomic, readwrite, assign) NSInteger previousNavigationIndex;
+@property(nonatomic, readwrite, assign) NSInteger previousItemIndex;
@property(nonatomic, readwrite, retain)
CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager;
@end
@@ -37,10 +37,9 @@ @interface CRWSessionController (ExposedForSerialization)
session_storage.hasOpener = web_state->HasOpener();
CRWSessionController* session_controller =
navigation_manager->GetSessionController();
- session_storage.currentNavigationIndex =
- session_controller.currentNavigationIndex;
- session_storage.previousNavigationIndex =
- session_controller.previousNavigationIndex;
+ session_storage.lastCommittedItemIndex =
+ session_controller.lastCommittedItemIndex;
+ session_storage.previousItemIndex = session_controller.previousItemIndex;
session_storage.sessionCertificatePolicyManager =
session_controller.sessionCertificatePolicyManager;
NSMutableArray* item_storages = [[NSMutableArray alloc] init];
@@ -71,13 +70,13 @@ @interface CRWSessionController (ExposedForSerialization)
item_storage_builder.BuildNavigationItemImpl(item_storages[index]);
items[index] = std::move(item_impl);
}
- NSUInteger current_index = storage.currentNavigationIndex;
+ NSUInteger last_committed_item_index = storage.lastCommittedItemIndex;
base::scoped_nsobject<CRWSessionController> session_controller(
- [[CRWSessionController alloc] initWithBrowserState:nullptr
- navigationItems:std::move(items)
- currentIndex:current_index]);
- [session_controller
- setPreviousNavigationIndex:storage.previousNavigationIndex];
+ [[CRWSessionController alloc]
+ initWithBrowserState:nullptr
+ navigationItems:std::move(items)
+ lastCommittedItemIndex:last_committed_item_index]);
+ [session_controller setPreviousItemIndex:storage.previousItemIndex];
[session_controller
setSessionCertificatePolicyManager:storage
.sessionCertificatePolicyManager];
« no previous file with comments | « ios/web/navigation/navigation_manager_impl_unittest.mm ('k') | ios/web/net/crw_ssl_status_updater_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698