Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: ios/web/navigation/navigation_manager_impl.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)
Patch Set: fix unit tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/navigation/navigation_manager_impl.mm
diff --git a/ios/web/navigation/navigation_manager_impl.mm b/ios/web/navigation/navigation_manager_impl.mm
index 8d3ccad5d1c72df4f5f424ea43a86b2aae556e7f..a059c1d0e3c19f4421442ccc06de66ddcc44dd38 100644
--- a/ios/web/navigation/navigation_manager_impl.mm
+++ b/ios/web/navigation/navigation_manager_impl.mm
@@ -104,11 +104,11 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
void NavigationManagerImpl::ReplaceSessionHistory(
std::vector<std::unique_ptr<web::NavigationItem>> items,
- int current_index) {
+ int lastCommittedItemIndex) {
SetSessionController([[CRWSessionController alloc]
- initWithBrowserState:browser_state_
- navigationItems:std::move(items)
- currentIndex:current_index]);
+ initWithBrowserState:browser_state_
+ navigationItems:std::move(items)
+ lastCommittedItemIndex:lastCommittedItemIndex]);
}
void NavigationManagerImpl::SetFacadeDelegate(
@@ -139,7 +139,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
LoadCommittedDetails details;
details.item = GetLastCommittedItem();
DCHECK(details.item);
- details.previous_item_index = [session_controller_ previousNavigationIndex];
+ details.previous_item_index = [session_controller_ previousItemIndex];
if (details.previous_item_index >= 0) {
DCHECK([session_controller_ previousItem]);
details.previous_url = [session_controller_ previousItem]->GetURL();
@@ -275,18 +275,14 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
return [session_controller_ itemAtIndex:index];
}
-int NavigationManagerImpl::GetCurrentItemIndex() const {
- return [session_controller_ currentNavigationIndex];
-}
-
int NavigationManagerImpl::GetPendingItemIndex() const {
if (GetPendingItem()) {
if ([session_controller_ pendingItemIndex] != -1) {
return [session_controller_ pendingItemIndex];
}
- // TODO(crbug.com/665189): understand why current item index is
+ // TODO(crbug.com/665189): understand why last committed item index is
// returned here.
- return GetCurrentItemIndex();
+ return GetLastCommittedItemIndex();
}
return -1;
}
@@ -294,7 +290,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
int NavigationManagerImpl::GetLastCommittedItemIndex() const {
if (GetItemCount() == 0)
return -1;
- return [session_controller_ currentNavigationIndex];
+ return [session_controller_ lastCommittedItemIndex];
}
bool NavigationManagerImpl::RemoveItemAtIndex(int index) {
@@ -369,7 +365,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
int NavigationManagerImpl::GetIndexForOffset(int offset) const {
int result = [session_controller_ pendingItemIndex] == -1
- ? GetCurrentItemIndex()
+ ? GetLastCommittedItemIndex()
: static_cast<int>([session_controller_ pendingItemIndex]);
if (offset < 0) {
@@ -446,7 +442,7 @@ bool AreURLsInPageNavigation(const GURL& existing_url, const GURL& new_url) {
NavigationItem* NavigationManagerImpl::GetLastCommittedNonAppSpecificItem()
const {
- int index = GetCurrentItemIndex();
+ int index = GetLastCommittedItemIndex();
if (index == -1)
return nullptr;
WebClient* client = GetWebClient();
« no previous file with comments | « ios/web/navigation/navigation_manager_impl.h ('k') | ios/web/navigation/navigation_manager_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698