ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm - Issue 2766063002: Remove the concept of currentItemIndex

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)

Patch Set: fix unit tests Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm

diff --git a/ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm b/ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm

index 072e0d80a8c097bf01e63bc8e9240fa8d1777d2f..a99d66b51d79499710bcb68017f5c66736306568 100644

--- a/ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm

+++ b/ios/chrome/browser/native_app_launcher/native_app_navigation_util.mm

@@ -18,7 +18,7 @@

bool IsLinkNavigation(web::WebState* web_state) {

web::NavigationManager* navigationManager = web_state->GetNavigationManager();

DCHECK(navigationManager);

- int index = navigationManager->GetCurrentItemIndex();

+ int index = navigationManager->GetLastCommittedItemIndex();

// Walks backward on the navigation items list looking for the first item

// that is not the result of a redirect. Check if user arrived at that

// via link click or a suggestion on the UI.

« no previous file with comments | « components/sessions/ios/ios_live_tab.mm ('k') | ios/chrome/browser/sync/ios_chrome_synced_tab_delegate.mm » ('j') | no next file with comments »