Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Unified Diff: ios/web/public/test/fakes/test_navigation_manager.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/public/test/fakes/test_navigation_manager.mm
diff --git a/ios/web/public/test/fakes/test_navigation_manager.mm b/ios/web/public/test/fakes/test_navigation_manager.mm
index 49cbc3b984ae419b0a460b60a6ee83a146ae17d1..bf98d9213c9023268c4e379276cb9ad126a39fb5 100644
--- a/ios/web/public/test/fakes/test_navigation_manager.mm
+++ b/ios/web/public/test/fakes/test_navigation_manager.mm
@@ -79,18 +79,13 @@
return items_[index].get();
}
-int TestNavigationManager::GetCurrentItemIndex() const {
- return items_index_;
-}
-
void TestNavigationManager::SetCurrentItemIndex(const int index) {
kkhorimoto 2017/03/21 23:54:16 Let's also change this to SetLastCommittedItemInde
liaoyuke 2017/03/22 18:50:37 Done.
DCHECK(index == -1 || index >= 0 && index < GetItemCount());
items_index_ = index;
}
int TestNavigationManager::GetLastCommittedItemIndex() const {
- NOTREACHED();
- return 0;
+ return items_index_;
}
int TestNavigationManager::GetPendingItemIndex() const {

Powered by Google App Engine
This is Rietveld 408576698