Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Side by Side Diff: ios/web/navigation/session_storage_builder.mm

Issue 2766063002: Remove the concept of currentItemIndex (Closed)
Patch Set: Addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/navigation/session_storage_builder.h" 5 #import "ios/web/navigation/session_storage_builder.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/mac/foundation_util.h" 8 #include "base/mac/foundation_util.h"
9 #import "ios/web/navigation/crw_session_controller+private_constructors.h" 9 #import "ios/web/navigation/crw_session_controller+private_constructors.h"
10 #import "ios/web/navigation/crw_session_controller.h" 10 #import "ios/web/navigation/crw_session_controller.h"
(...skipping 20 matching lines...) Expand all
31 WebStateImpl* web_state) const { 31 WebStateImpl* web_state) const {
32 DCHECK(web_state); 32 DCHECK(web_state);
33 web::NavigationManagerImpl* navigation_manager = 33 web::NavigationManagerImpl* navigation_manager =
34 web_state->navigation_manager_.get(); 34 web_state->navigation_manager_.get();
35 DCHECK(navigation_manager); 35 DCHECK(navigation_manager);
36 CRWSessionStorage* session_storage = [[CRWSessionStorage alloc] init]; 36 CRWSessionStorage* session_storage = [[CRWSessionStorage alloc] init];
37 session_storage.hasOpener = web_state->HasOpener(); 37 session_storage.hasOpener = web_state->HasOpener();
38 CRWSessionController* session_controller = 38 CRWSessionController* session_controller =
39 navigation_manager->GetSessionController(); 39 navigation_manager->GetSessionController();
40 session_storage.currentNavigationIndex = 40 session_storage.currentNavigationIndex =
41 session_controller.currentNavigationIndex; 41 session_controller.lastCommittedItemIndex;
42 session_storage.previousNavigationIndex = 42 session_storage.previousNavigationIndex =
43 session_controller.previousNavigationIndex; 43 session_controller.previousNavigationIndex;
44 session_storage.sessionCertificatePolicyManager = 44 session_storage.sessionCertificatePolicyManager =
45 session_controller.sessionCertificatePolicyManager; 45 session_controller.sessionCertificatePolicyManager;
46 NSMutableArray* item_storages = [[NSMutableArray alloc] init]; 46 NSMutableArray* item_storages = [[NSMutableArray alloc] init];
47 NavigationItemStorageBuilder item_storage_builder; 47 NavigationItemStorageBuilder item_storage_builder;
48 for (size_t index = 0; index < session_controller.items.size(); ++index) { 48 for (size_t index = 0; index < session_controller.items.size(); ++index) {
49 web::NavigationItemImpl* item = session_controller.items[index].get(); 49 web::NavigationItemImpl* item = session_controller.items[index].get();
50 [item_storages addObject:item_storage_builder.BuildStorage(item)]; 50 [item_storages addObject:item_storage_builder.BuildStorage(item)];
51 } 51 }
(...skipping 29 matching lines...) Expand all
81 [session_controller 81 [session_controller
82 setSessionCertificatePolicyManager:storage 82 setSessionCertificatePolicyManager:storage
83 .sessionCertificatePolicyManager]; 83 .sessionCertificatePolicyManager];
84 web_state->navigation_manager_.reset(new NavigationManagerImpl()); 84 web_state->navigation_manager_.reset(new NavigationManagerImpl());
85 web_state->navigation_manager_->SetSessionController(session_controller); 85 web_state->navigation_manager_->SetSessionController(session_controller);
86 web::SerializableUserDataManager::FromWebState(web_state) 86 web::SerializableUserDataManager::FromWebState(web_state)
87 ->AddSerializableUserData(storage.userData); 87 ->AddSerializableUserData(storage.userData);
88 } 88 }
89 89
90 } // namespace web 90 } // namespace web
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698