[refactor] Fix autofill features for payments when the form is inside an OOPIF

content/renderer/render_widget.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_widget.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/auto_reset.h"
@@ skipping 954 matching lines @@
 std::unique_ptr<cc::SwapPromise> RenderWidget::RequestCopyOfOutputForLayoutTest(
     std::unique_ptr<cc::CopyOutputRequest> request) {
   return RenderThreadImpl::current()->RequestCopyOfOutputForLayoutTest(
       routing_id_, std::move(request));
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 // RenderWidgetInputHandlerDelegate
 
 void RenderWidget::FocusChangeComplete() {
-  if (owner_delegate_)
-    owner_delegate_->RenderWidgetFocusChangeComplete();
+  for (auto& render_frame : render_frames_)
+    render_frame.DidCompleteFocusChange();

[Charlie Reis, 2017/04/05 20:13:45]

How often is this called?  I'm mildly concerned about having to notify every
frame in a potentially large page every time the focus changes, which seems like
it could be quite frequent.

It looks like most of those frames just ignore the call anyway-- only the
focused frame will react.  Would it be sufficient to only notify the focused
frame from here?

[EhsanK, 2017/04/06 21:31:28]

I think quite often and basically whenever we focus an element.
I would appreciate adding a legal way to directly communicate with
RenderFrame(s) or at least the RenderView from here. But unfortunately this does
not seem to be the way things are intended in RenderWidget as there is no notion
of RenderView, RenderFrame, or focused frame anywhere in this file.

Adding knowledge of frame tree or some frames to RenderWidget solves some
problems such as the pointer to focused_pepper_plugin_ we keep here or handling
page focus in OOPIFs (https://crbug.com/643727 and https://crbug.com/689777).

[Charlie Reis, 2017/04/10 06:22:33]

Daniel and Ken, what are your thoughts on this?  RenderWidget already has a list
of render_frames_ that it uses for notifying observers.  Would it make sense to
give it a notion of the focused frame so that it can handle cases like this
without iterating over all frames?

 }
 
 bool RenderWidget::HasTouchEventHandlersAt(const gfx::Point& point) const {
   if (owner_delegate_)
     return owner_delegate_->DoesRenderWidgetHaveTouchEventHandlersAt(point);
 
   return true;
 }
 
 void RenderWidget::ObserveGestureEventAndResult(
@@ skipping 1338 matching lines @@
     // browser side (https://crbug.com/669219).
     // If there is no WebFrameWidget, then there will be no
     // InputMethodControllers for a WebLocalFrame.
     return nullptr;
   }
   return static_cast<blink::WebFrameWidget*>(GetWebWidget())
       ->getActiveWebInputMethodController();
 }
 
 }  // namespace content