[refactor] Fix autofill features for payments when the form is inside an OOPIF

content/renderer/render_frame_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 231 matching lines @@
   static void InstallCreateHook(
       CreateRenderFrameImplFunction create_render_frame_impl);
 
   // Looks up and returns the WebFrame corresponding to a given opener frame
   // routing ID.
   static blink::WebFrame* ResolveOpener(int opener_frame_routing_id);
 
   // Overwrites the given URL to use an HTML5 embed if possible.
   blink::WebURL overrideFlashEmbedWithHTML(const blink::WebURL& url) override;
 
+  void didCompleteLeftMouseDownOrGestureTapInNode(
+      const blink::WebNode& node) override;

[Charlie Reis, 2017/04/05 20:13:45]

This should be in the WebFrameClient overrides section around line 693 (as
should overrideFlashEmbedWithHTML).

[EhsanK, 2017/04/06 21:31:28]

Thanks. I moved both. Also deleted the comment above overrideFlasEmbedWithHTML
as exactly the first sentence in the comment for
WebFrameClient::overrideFlashEmbedWithHTML.

+
   ~RenderFrameImpl() override;
 
   // Called by RenderWidget when meaningful layout has happened.
   // See RenderFrameObserver::DidMeaningfulLayout declaration for details.
   void DidMeaningfulLayout(blink::WebMeaningfulLayout layout_type);
 
   // Out-of-process child frames receive a signal from RenderWidgetCompositor
   // when a compositor frame has committed.
   void DidCommitCompositorFrame();
 
   // Draw commands have been issued by RenderWidgetCompositor.
   void DidCommitAndDrawCompositorFrame();
 
   // Returns the unique name of the RenderFrame.
   const std::string& unique_name() const { return unique_name_helper_.value(); }
 
+  // Called by render widget to notify about a change in focused element.

[Charlie Reis, 2017/04/05 20:13:45]

nit: RenderWidget

Might want to clarify that this is called on every frame, if we stick with that
decision.

[EhsanK, 2017/04/06 21:31:28]

Done. Thanks!

+  void DidCompleteFocusChange();
+
+  // Called by render widget to notify about handling a left mouse down or

[Charlie Reis, 2017/04/05 20:13:45]

nit: RenderWidget

[EhsanK, 2017/04/06 21:31:28]

Done.

+  // gesture tap in |node|. |node| belongs to a frame inside the subtree rooted
+  // at the local root and is never null.

[Charlie Reis, 2017/04/05 20:13:45]

I'm not clear on this explanation.  Are you saying it's called on the local
root's RenderFrameImpl, and not on the frame |node| is in?  That's a bit
confusing (especially next to DidCompleteFocusChange, which is apparently called
on every frame), so it's worth clarifying.

[EhsanK, 2017/04/06 21:31:28]

Sorry about this code and comment. I forgot to remove this from previous patch.
The logic is now in WebFrameClient (RenderFrameImpl) and does not go to
WebWidgetClient and then to all RenderFrameImpls. Now we directly call
WebFrameClient::didCompleteLeftMouseDownOrGestureTapInNode().

+  void DidCompleteLeftMouseDownOrGestureTapInNode(const blink::WebNode& node);

[Charlie Reis, 2017/04/05 20:13:45]

This isn't implemented or called.  Is it stale code, or would compile or tests
have caught it?

[EhsanK, 2017/04/06 21:31:28]

Stale code from previous patch. Apologies. Thanks!

+
   // TODO(jam): this is a temporary getter until all the code is transitioned
   // to using RenderFrame instead of RenderView.
   RenderViewImpl* render_view() { return render_view_; }
 
   const blink::WebHistoryItem& current_history_item() {
     return current_history_item_;
   }
 
   RendererWebCookieJarImpl* cookie_jar() { return &cookie_jar_; }
 
@@ skipping 1146 matching lines @@
   std::unique_ptr<PendingNavigationInfo> pending_navigation_info_;
 
   base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_