[refactor] Fix autofill features for payments when the form is inside an OOPIF

content/public/renderer/render_frame_observer.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
 #define CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_
 
 #include <stdint.h>
 
 #include "base/compiler_specific.h"
@@ skipping 100 matching lines @@
   virtual void DidChangePerformanceTiming() {}
 
   // Notification when the renderer uses a particular code path during a page
   // load. This is used for metrics collection.
   virtual void DidObserveLoadingBehavior(
       blink::WebLoadingBehaviorFlag behavior) {}
 
   // Called when the focused node has changed to |node|.
   virtual void FocusedNodeChanged(const blink::WebNode& node) {}
 
+  // Called when an element has gained focus inside the frame and after all the
+  // required animations (if any)  have finished.

[Charlie Reis, 2017/04/05 20:13:44]

nit: Fix double space before "have"

[EhsanK, 2017/04/06 21:31:27]

Done. Thanks!

+  virtual void DidCompleteFocusChangeInFrame() {}
+
+  // Called when a gesture tap or mouse down occurs inside |node| in this frame.
+  virtual void DidCompleteLeftMouseDownOrGestureTapInNode(

[Charlie Reis, 2017/04/05 20:13:44]

This name is a bit awkward, but I'm ok with it if you need to be this specific. 
That said, it looks like it's not hooked up.  :)

[EhsanK, 2017/04/06 21:31:27]

Yes I was not sure how it should be named. In reality the method was called when
there is a mouse down or tap. The name inside blink is onMouseDown but I figured
that might be a bit incorrect given that it is not necessarily on mouse down.
But I am open to any suggestion regarding the naming (that is if this method
survives the patch given that there is a possibility of moving the logic to
WebAutofillClient).

Also, this is implemented in PageClickTracker which is one of the 
RenderFrameObservers in this patch; and should get called from
RenderFrameImpl::didCompleteLeftMouseDownOrGestureTapInNode().

[Charlie Reis, 2017/04/10 06:22:33]

Ah, my mistake!  I was reading it wrong.

+      const blink::WebNode& node) {}
+
   // Called when accessibility is enabled or disabled.
   virtual void AccessibilityModeChanged() {}
 
   // Called when script in the page calls window.print().
   virtual void ScriptedPrint(bool user_initiated) {}
 
   // IPC::Listener implementation.
   bool OnMessageReceived(const IPC::Message& message) override;
 
   // IPC::Sender implementation.
@@ skipping 16 matching lines @@
   RenderFrame* render_frame_;
   // The routing ID of the associated RenderFrame.
   int routing_id_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameObserver);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_RENDERER_RENDER_FRAME_OBSERVER_H_