Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1632)

Unified Diff: chrome/browser/renderer_host/buffered_resource_handler.cc

Issue 2766007: Merge 49411 - UseAlternateResourceHandler should set the non-owning pointer... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/375/src/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/buffered_resource_handler.cc
===================================================================
--- chrome/browser/renderer_host/buffered_resource_handler.cc (revision 49561)
+++ chrome/browser/renderer_host/buffered_resource_handler.cc (working copy)
@@ -304,7 +304,6 @@
// Check if this is an X.509 certificate, if yes, let it be handled
// by X509UserCertResourceHandler.
if (mime_type == "application/x-x509-user-cert") {
-
// This is entirely similar to how DownloadThrottlingResourceHandler
// works except we are doing it for an X.509 client certificates.
@@ -457,6 +456,11 @@
URLRequestStatus status(URLRequestStatus::HANDLED_EXTERNALLY, 0);
real_handler_->OnResponseCompleted(info->request_id(), status, std::string());
+ // Remove the non-owning pointer to the CrossSiteResourceHandler, if any,
+ // from the extra request info because the CrossSiteResourceHandler (part of
+ // the original ResourceHandler chain) will be deleted by the next statement.
+ info->set_cross_site_handler(NULL);
+
// This is handled entirely within the new ResourceHandler, so just reset the
// original ResourceHandler.
real_handler_ = handler;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698