Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2765953002: Format generated files. (Closed)

Created:
3 years, 9 months ago by devoncarew
Modified:
3 years, 9 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2872 lines, -1727 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 434 chunks +2158 lines, -932 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_test_methods.dart View 27 chunks +150 lines, -71 lines 0 comments Download
M pkg/analysis_server/test/integration/protocol_matchers.dart View 128 chunks +526 lines, -717 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/codegen_java_types.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/analyzer_plugin/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/codegen/tools.dart View 4 chunks +36 lines, -1 line 2 comments Download

Messages

Total messages: 7 (2 generated)
devoncarew
Format generated files in the analyzer.
3 years, 9 months ago (2017-03-21 19:23:20 UTC) #2
Brian Wilkerson
lgtm
3 years, 9 months ago (2017-03-21 19:37:53 UTC) #3
Jacob
Thanks for doing this! lgtm https://codereview.chromium.org/2765953002/diff/1/pkg/front_end/lib/src/codegen/tools.dart File pkg/front_end/lib/src/codegen/tools.dart (right): https://codereview.chromium.org/2765953002/diff/1/pkg/front_end/lib/src/codegen/tools.dart#newcode87 pkg/front_end/lib/src/codegen/tools.dart:87: print("Generating..."); did you mean ...
3 years, 9 months ago (2017-03-21 19:41:08 UTC) #4
devoncarew
https://codereview.chromium.org/2765953002/diff/1/pkg/front_end/lib/src/codegen/tools.dart File pkg/front_end/lib/src/codegen/tools.dart (right): https://codereview.chromium.org/2765953002/diff/1/pkg/front_end/lib/src/codegen/tools.dart#newcode87 pkg/front_end/lib/src/codegen/tools.dart:87: print("Generating..."); On 2017/03/21 19:41:07, Jacob wrote: > did you ...
3 years, 9 months ago (2017-03-21 22:50:58 UTC) #5
devoncarew
3 years, 9 months ago (2017-03-21 22:54:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a231501692fe5881d9a136bb9783a6396afd7193 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698