Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 276593008: Fix RecvMsgWithPid on broken socket pair (Closed)

Created:
6 years, 7 months ago by mdempsky
Modified:
6 years, 7 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Fix RecvMsgWithPid on broken socket pair This prevents RecvMsgWithPid from DCHECK failing under Debug builds when reading EOF from a broken socket pair. Noticed while testing crrev.com/269543014. Unfortunately, Linux allows sending zero length messages that the recvmsg() API does not distinguish from reading EOF. To be conservative, if we didn't receive any message or control bytes, then assume we received an EOF and tolerate not knowing the sender's PID. BUG=357670 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270967

Patch Set 1 #

Patch Set 2 : Use DCHECK_GE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -1 line) Patch
M base/posix/unix_domain_socket_linux.cc View 1 1 chunk +7 lines, -1 line 0 comments Download
M base/posix/unix_domain_socket_linux_unittest.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
mdempsky
6 years, 7 months ago (2014-05-08 17:56:08 UTC) #1
jln (very slow on Chromium)
lgtm
6 years, 7 months ago (2014-05-08 21:55:04 UTC) #2
mdempsky
ajwong: Will you please review and approve for base OWNERS? Thanks!
6 years, 7 months ago (2014-05-08 21:56:26 UTC) #3
mdempsky
On 2014/05/08 21:56:26, mdempsky wrote: > ajwong: Will you please review and approve for base ...
6 years, 7 months ago (2014-05-12 17:02:28 UTC) #4
awong
LGTM sorry for the delay
6 years, 7 months ago (2014-05-16 05:46:34 UTC) #5
mdempsky
The CQ bit was checked by mdempsky@chromium.org
6 years, 7 months ago (2014-05-16 05:50:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mdempsky@chromium.org/276593008/20001
6 years, 7 months ago (2014-05-16 05:50:50 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 07:51:51 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 08:57:59 UTC) #9
Message was sent while issue was closed.
Change committed as 270967

Powered by Google App Engine
This is Rietveld 408576698