Issue 276593007: Replace VideoRendererImpl's kError state with a CHECK().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 276593007: Replace VideoRendererImpl's kError state with a CHECK(). (Closed)

Created:
6 years, 7 months ago by scherkus (not reviewing)

Modified:
6 years, 7 months ago

Reviewers:
xhwang

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Replace VideoRendererImpl's kError state with a CHECK(). If the process is unable to create a new thread we've got bigger issues to deal with than reporting an error. A CHECK() will also give us a sense for how often this happens in the wild. BUG=110814 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269621

Patch Set 1 #

Patch Set 2 : rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -12 lines)			Patch
	M	media/filters/video_renderer_impl.h	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
	M	media/filters/video_renderer_impl.cc	View	1	4 chunks	+3 lines, -9 lines	0 comments	Download