Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 276593004: Greenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2207 (Closed)

Created:
6 years, 7 months ago by benchen
Modified:
6 years, 7 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Greenify bench bot Perf-Win7-ShuttleA-HD2000-x86-Release at build 2207 TBR=bsalomon@google.com NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=14637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M expectations/bench/bench_expectations_Perf-Win7-ShuttleA-HD2000-x86-Release.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
benchen
The CQ bit was checked by bensong@google.com
6 years, 7 months ago (2014-05-08 04:57:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/276593004/1
6 years, 7 months ago (2014-05-08 04:57:50 UTC) #2
commit-bot: I haz the power
Change committed as 14637
6 years, 7 months ago (2014-05-08 04:58:00 UTC) #3
bsalomon
On 2014/05/08 04:58:00, I haz the power (commit-bot) wrote: > Change committed as 14637 lgtm. ...
6 years, 7 months ago (2014-05-08 14:34:18 UTC) #4
benchen
6 years, 7 months ago (2014-05-08 14:39:12 UTC) #5
Message was sent while issue was closed.
On 2014/05/08 14:34:18, bsalomon wrote:
> On 2014/05/08 04:58:00, I haz the power (commit-bot) wrote:
> > Change committed as 14637
> 
> lgtm. Next time one of these comes up could you send me an email or chat? I'd
> like to try the tools out myself, but I'm not always watching the tree closely
> enough to notice when it needs to be done.

Thank you Brian! In fact currently Nexus 4 and 7 both have one small outlier.
http://108.170.220.21:10117/builders/Perf-Android-Nexus4-Adreno320-Arm7-Relea...
http://108.170.220.21:10117/builders/Perf-Android-Nexus7-Tegra3-Arm7-Release/...

So if you copy /google/data/ro/teams/skia/greenify.py to a clean local dir and
run
./greenify.py --url <one of the urls above>
it should work. Let me know of any issues. I'm at the airport now but will
respond when I can. Thanks!

Powered by Google App Engine
This is Rietveld 408576698