Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2054)

Unified Diff: tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart

Issue 2765893003: Fix warnings_checker.dart handling of multitests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/constructor_kinds_test.dart ('k') | tests/lib/mirrors/generic_bounded_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
diff --git a/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart b/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
index 3b05fecf452588e32812286f628876e5a2350029..388274a1de8fe5455dc1713cae5e27c9b398b127 100644
--- a/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
+++ b/tests/lib/mirrors/generic_bounded_by_type_parameter_test.dart
@@ -12,8 +12,8 @@ import 'generics_helper.dart';
class Super<T, R extends T> {}
class Fixed extends Super<num, int> {}
-class Generic<X, Y> extends Super<X, Y> {} /// 02: static type warning
-class Malbounded extends Super<num, String> {} /// 01: static type warning
+class Generic<X, Y> extends Super<X, Y> {} //# 02: static type warning
+class Malbounded extends Super<num, String> {} //# 01: static type warning
bool inCheckedMode() {
try {
@@ -28,57 +28,57 @@ bool inCheckedMode() {
main() {
ClassMirror superDecl = reflectClass(Super);
ClassMirror superOfNumAndInt = reflectClass(Fixed).superclass;
- ClassMirror genericDecl = reflectClass(Generic); // /// 02: continued
- ClassMirror superOfXAndY = genericDecl.superclass; // /// 02: continued
- ClassMirror genericOfNumAndDouble = reflect(new Generic<num, double>()).type; // /// 02: continued
- ClassMirror superOfNumAndDouble = genericOfNumAndDouble.superclass; // /// 02: continued
- ClassMirror superOfNumAndString = reflectClass(Malbounded).superclass; // /// 01: continued
+ ClassMirror genericDecl = reflectClass(Generic); // //# 02: continued
+ ClassMirror superOfXAndY = genericDecl.superclass; // //# 02: continued
+ ClassMirror genericOfNumAndDouble = reflect(new Generic<num, double>()).type; // //# 02: continued
+ ClassMirror superOfNumAndDouble = genericOfNumAndDouble.superclass; // //# 02: continued
+ ClassMirror superOfNumAndString = reflectClass(Malbounded).superclass; // //# 01: continued
try {
- ClassMirror genericOfNumAndBool = reflect(new Generic<num, bool>()).type; // /// 02: static type warning
- ClassMirror superOfNumAndBool = genericOfNumAndBool.superclass; // /// 02: continued
- Expect.isFalse(genericOfNumAndBool.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfNumAndBool.isOriginalDeclaration); // /// 02: continued
- typeParameters(genericOfNumAndBool, [#X, #Y]); // /// 02: continued
- typeParameters(superOfNumAndBool, [#T, #R]); // /// 02: continued
- typeArguments(genericOfNumAndBool, [reflectClass(num), reflectClass(bool)]); // /// 02: continued
- typeArguments(superOfNumAndBool, [reflectClass(num), reflectClass(bool)]); // /// 02: continued
- Expect.isFalse(inCheckedMode()); /// 02: continued
+ ClassMirror genericOfNumAndBool = reflect(new Generic<num, bool>()).type; // //# 02: static type warning
+ ClassMirror superOfNumAndBool = genericOfNumAndBool.superclass; // //# 02: continued
+ Expect.isFalse(genericOfNumAndBool.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfNumAndBool.isOriginalDeclaration); // //# 02: continued
+ typeParameters(genericOfNumAndBool, [#X, #Y]); // //# 02: continued
+ typeParameters(superOfNumAndBool, [#T, #R]); // //# 02: continued
+ typeArguments(genericOfNumAndBool, [reflectClass(num), reflectClass(bool)]); // //# 02: continued
+ typeArguments(superOfNumAndBool, [reflectClass(num), reflectClass(bool)]); // //# 02: continued
+ Expect.isFalse(inCheckedMode()); //# 02: continued
} on TypeError catch(e) {
Expect.isTrue(inCheckedMode());
}
Expect.isTrue(superDecl.isOriginalDeclaration);
Expect.isFalse(superOfNumAndInt.isOriginalDeclaration);
- Expect.isTrue(genericDecl.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfXAndY.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(genericOfNumAndDouble.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfNumAndDouble.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfNumAndString.isOriginalDeclaration); // /// 01: continued
+ Expect.isTrue(genericDecl.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfXAndY.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(genericOfNumAndDouble.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfNumAndDouble.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfNumAndString.isOriginalDeclaration); // //# 01: continued
TypeVariableMirror tFromSuper = superDecl.typeVariables[0];
TypeVariableMirror rFromSuper = superDecl.typeVariables[1];
- TypeVariableMirror xFromGeneric = genericDecl.typeVariables[0]; // /// 02: continued
- TypeVariableMirror yFromGeneric = genericDecl.typeVariables[1]; // /// 02: continued
+ TypeVariableMirror xFromGeneric = genericDecl.typeVariables[0]; // //# 02: continued
+ TypeVariableMirror yFromGeneric = genericDecl.typeVariables[1]; // //# 02: continued
Expect.equals(reflectClass(Object), tFromSuper.upperBound);
Expect.equals(tFromSuper, rFromSuper.upperBound);
- Expect.equals(reflectClass(Object), xFromGeneric.upperBound); // /// 02: continued
- Expect.equals(reflectClass(Object), yFromGeneric.upperBound); // /// 02: continued
+ Expect.equals(reflectClass(Object), xFromGeneric.upperBound); // //# 02: continued
+ Expect.equals(reflectClass(Object), yFromGeneric.upperBound); // //# 02: continued
typeParameters(superDecl, [#T, #R]);
typeParameters(superOfNumAndInt, [#T, #R]);
- typeParameters(genericDecl, [#X, #Y]); // /// 02: continued
- typeParameters(superOfXAndY, [#T, #R]); // /// 02: continued
- typeParameters(genericOfNumAndDouble, [#X, #Y]); // /// 02: continued
- typeParameters(superOfNumAndDouble, [#T, #R]); // /// 02: continued
- typeParameters(superOfNumAndString, [#T, #R]); // /// 01: continued
+ typeParameters(genericDecl, [#X, #Y]); // //# 02: continued
+ typeParameters(superOfXAndY, [#T, #R]); // //# 02: continued
+ typeParameters(genericOfNumAndDouble, [#X, #Y]); // //# 02: continued
+ typeParameters(superOfNumAndDouble, [#T, #R]); // //# 02: continued
+ typeParameters(superOfNumAndString, [#T, #R]); // //# 01: continued
typeArguments(superDecl, []);
typeArguments(superOfNumAndInt, [reflectClass(num), reflectClass(int)]);
- typeArguments(genericDecl, []); // /// 02: continued
- typeArguments(superOfXAndY, [xFromGeneric, yFromGeneric]); // /// 02: continued
- typeArguments(genericOfNumAndDouble, [reflectClass(num), reflectClass(double)]); // /// 02: continued
- typeArguments(superOfNumAndDouble, [reflectClass(num), reflectClass(double)]); // /// 02: continued
- typeArguments(superOfNumAndString, [reflectClass(num), reflectClass(String)]); // /// 01: continued
+ typeArguments(genericDecl, []); // //# 02: continued
+ typeArguments(superOfXAndY, [xFromGeneric, yFromGeneric]); // //# 02: continued
+ typeArguments(genericOfNumAndDouble, [reflectClass(num), reflectClass(double)]); // //# 02: continued
+ typeArguments(superOfNumAndDouble, [reflectClass(num), reflectClass(double)]); // //# 02: continued
+ typeArguments(superOfNumAndString, [reflectClass(num), reflectClass(String)]); // //# 01: continued
}
« no previous file with comments | « tests/lib/mirrors/constructor_kinds_test.dart ('k') | tests/lib/mirrors/generic_bounded_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698