Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: tests/language/async_test.dart

Issue 2765893003: Fix warnings_checker.dart handling of multitests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/async_switch_test.dart ('k') | tests/language/async_throw_in_catch_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/language/async_test.dart
diff --git a/tests/language/async_test.dart b/tests/language/async_test.dart
index 5a7886b275e0bc6c81e3fa506842612bf3c4eece..e85cece6bc573350dae13fd831d97f29f690ad19 100644
--- a/tests/language/async_test.dart
+++ b/tests/language/async_test.dart
@@ -13,7 +13,7 @@ Future<int> topLevelWithParameter(int a) async {
return 7 + a;
}
-int /// type-mismatch2: static type warning, dynamic type error
+int //# type-mismatch2: static type warning, dynamic type error
topLevelWithParameterWrongType(int a) async {
return 7 + a;
}
@@ -32,11 +32,11 @@ class A {
int _x;
A(this._x);
- A.fail() async; // /// constructor2: compile-time error
- factory A.create() async {return null; } /// constructor3: compile-time error
+ A.fail() async; // //# constructor2: compile-time error
+ factory A.create() async {return null; } //# constructor3: compile-time error
- int someMethod(int param1, int param2, int param3) async => _x + param2; /// type-mismatch3: static type warning, dynamic type error
- int get getter async { return 5 + _x; } /// type-mismatch4: static type warning, dynamic type error
+ int someMethod(int param1, int param2, int param3) async => _x + param2; //# type-mismatch3: static type warning, dynamic type error
+ int get getter async { return 5 + _x; } //# type-mismatch4: static type warning, dynamic type error
operator+(A other) async {
return new A(_x + other._x);
}
@@ -47,11 +47,11 @@ class A {
class B {
final _y;
const B._internal(this._y);
- const factory B.createConst(int y) async = A._internal; // /// constructor4: compile-time error
+ const factory B.createConst(int y) async = A._internal; // //# constructor4: compile-time error
B() : _y = null;
- set dontDoThat(value) async {} // /// setter1: compile-time error
+ set dontDoThat(value) async {} // //# setter1: compile-time error
}
@@ -61,8 +61,8 @@ main() {
asyncReturn = topLevelFunction();
Expect.isTrue(asyncReturn is Future);
- int a1 = topLevelWithParameter(2); // /// type-mismatch1: static type warning, dynamic type error
- int a2 = topLevelWithParameterWrongType(2); // /// type-mismatch2: continued
+ int a1 = topLevelWithParameter(2); // //# type-mismatch1: static type warning, dynamic type error
+ int a2 = topLevelWithParameterWrongType(2); // //# type-mismatch2: continued
asyncReturn = topLevelWithParameter(4);
Expect.isTrue(asyncReturn is Future);
asyncReturn.then((int result) => Expect.equals(result, 11));
@@ -82,13 +82,13 @@ main() {
A a = new A(13);
- asyncReturn = a.someMethod(1,2,3); // /// type-mismatch3: continued
- Expect.isTrue(asyncReturn is Future); // /// type-mismatch3: continued
- asyncReturn.then((int result) => Expect.equals(result, 15)); // /// type-mismatch3: continued
+ asyncReturn = a.someMethod(1,2,3); // //# type-mismatch3: continued
+ Expect.isTrue(asyncReturn is Future); // //# type-mismatch3: continued
+ asyncReturn.then((int result) => Expect.equals(result, 15)); // //# type-mismatch3: continued
- asyncReturn = a.getter; // /// type-mismatch4: continued
- Expect.isTrue(asyncReturn is Future); // /// type-mismatch4: continued
- asyncReturn.then((int result) => Expect.equals(result, 18)); // /// type-mismatch4: continued
+ asyncReturn = a.getter; // //# type-mismatch4: continued
+ Expect.isTrue(asyncReturn is Future); // //# type-mismatch4: continued
+ asyncReturn.then((int result) => Expect.equals(result, 18)); // //# type-mismatch4: continued
var b = new A(9);
asyncReturn = a + b;
@@ -115,9 +115,9 @@ main() {
Expect.isTrue(asyncReturn is Future);
asyncReturn.then((int result) => Expect.equals(result, 28));
- var b1 = const B.createConst(4); // /// constructor4: compile-time error
+ var b1 = const B.createConst(4); // //# constructor4: compile-time error
var b2 = new B();
- b2.dontDoThat = 4; // /// setter1: compile-time error
+ b2.dontDoThat = 4; // //# setter1: compile-time error
var checkAsync = (var someFunc) {
var toTest = someFunc();
@@ -126,6 +126,6 @@ main() {
};
checkAsync(() async => 4);
- new A.fail(); /// constructor2: continued
- new A.create(); /// constructor3: continued
+ new A.fail(); //# constructor2: continued
+ new A.create(); //# constructor3: continued
}
« no previous file with comments | « tests/language/async_switch_test.dart ('k') | tests/language/async_throw_in_catch_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698