Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: tests/lib_strong/mirrors/generic_bounded_test.dart

Issue 2765893003: Fix warnings_checker.dart handling of multitests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/lib_strong/mirrors/generic_bounded_test.dart
diff --git a/tests/lib_strong/mirrors/generic_bounded_test.dart b/tests/lib_strong/mirrors/generic_bounded_test.dart
index d581104acfd09b50010de75aa224f1cb21d7d276..5afc22832724bcf4d1cb5ede86115df506bbe647 100644
--- a/tests/lib_strong/mirrors/generic_bounded_test.dart
+++ b/tests/lib_strong/mirrors/generic_bounded_test.dart
@@ -13,8 +13,8 @@ import 'generics_helper.dart';
class Super<T extends num> {}
class Fixed extends Super<int> {}
-class Generic<R> extends Super<R> {} // /// 02: static type warning
-class Malbounded extends Super<String> {} /// 01: static type warning
+class Generic<R> extends Super<R> {} // //# 02: static type warning
+class Malbounded extends Super<String> {} //# 01: static type warning
bool inCheckedMode() {
try {
@@ -29,55 +29,55 @@ bool inCheckedMode() {
main() {
ClassMirror superDecl = reflectClass(Super);
ClassMirror superOfInt = reflectClass(Fixed).superclass;
- ClassMirror genericDecl = reflectClass(Generic); // /// 02: continued
- ClassMirror superOfR = genericDecl.superclass; // /// 02: continued
- ClassMirror genericOfDouble = reflect(new Generic<double>()).type; // /// 02: continued
- ClassMirror superOfDouble = genericOfDouble.superclass; // /// 02: continued
+ ClassMirror genericDecl = reflectClass(Generic); // //# 02: continued
+ ClassMirror superOfR = genericDecl.superclass; // //# 02: continued
+ ClassMirror genericOfDouble = reflect(new Generic<double>()).type; // //# 02: continued
+ ClassMirror superOfDouble = genericOfDouble.superclass; // //# 02: continued
try {
- ClassMirror genericOfBool = reflect(new Generic<bool>()).type; // /// 02: static type warning
- ClassMirror superOfBool = genericOfBool.superclass; // /// 02: continued
- Expect.isFalse(genericOfBool.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfBool.isOriginalDeclaration); // /// 02: continued
- typeParameters(genericOfBool, [#R]); // /// 02: continued
- typeParameters(superOfBool, [#T]); // /// 02: continued
- typeArguments(genericOfBool, [reflectClass(bool)]); // /// 02: continued
- typeArguments(superOfBool, [reflectClass(bool)]); // /// 02: continued
- Expect.isFalse(inCheckedMode()); /// 02: continued
+ ClassMirror genericOfBool = reflect(new Generic<bool>()).type; // //# 02: static type warning
+ ClassMirror superOfBool = genericOfBool.superclass; // //# 02: continued
+ Expect.isFalse(genericOfBool.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfBool.isOriginalDeclaration); // //# 02: continued
+ typeParameters(genericOfBool, [#R]); // //# 02: continued
+ typeParameters(superOfBool, [#T]); // //# 02: continued
+ typeArguments(genericOfBool, [reflectClass(bool)]); // //# 02: continued
+ typeArguments(superOfBool, [reflectClass(bool)]); // //# 02: continued
+ Expect.isFalse(inCheckedMode()); //# 02: continued
} on TypeError catch(e) {
Expect.isTrue(inCheckedMode());
}
- ClassMirror superOfString = reflectClass(Malbounded).superclass; // /// 01: continued
+ ClassMirror superOfString = reflectClass(Malbounded).superclass; // //# 01: continued
Expect.isTrue(superDecl.isOriginalDeclaration);
Expect.isFalse(superOfInt.isOriginalDeclaration);
- Expect.isTrue(genericDecl.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfR.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(genericOfDouble.isOriginalDeclaration); // /// 02: continued
- Expect.isFalse(superOfDouble.isOriginalDeclaration); // /// 02: continued
+ Expect.isTrue(genericDecl.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfR.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(genericOfDouble.isOriginalDeclaration); // //# 02: continued
+ Expect.isFalse(superOfDouble.isOriginalDeclaration); // //# 02: continued
- Expect.isFalse(superOfString.isOriginalDeclaration); // /// 01: continued
+ Expect.isFalse(superOfString.isOriginalDeclaration); // //# 01: continued
TypeVariableMirror tFromSuper = superDecl.typeVariables.single;
- TypeVariableMirror rFromGeneric = genericDecl.typeVariables.single; // /// 02: continued
+ TypeVariableMirror rFromGeneric = genericDecl.typeVariables.single; // //# 02: continued
Expect.equals(reflectClass(num), tFromSuper.upperBound);
- Expect.equals(reflectClass(Object), rFromGeneric.upperBound); // /// 02: continued
+ Expect.equals(reflectClass(Object), rFromGeneric.upperBound); // //# 02: continued
typeParameters(superDecl, [#T]);
typeParameters(superOfInt, [#T]);
- typeParameters(genericDecl, [#R]); // /// 02: continued
- typeParameters(superOfR, [#T]); // /// 02: continued
- typeParameters(genericOfDouble, [#R]); // /// 02: continued
- typeParameters(superOfDouble, [#T]); // /// 02: continued
- typeParameters(superOfString, [#T]); // /// 01: continued
+ typeParameters(genericDecl, [#R]); // //# 02: continued
+ typeParameters(superOfR, [#T]); // //# 02: continued
+ typeParameters(genericOfDouble, [#R]); // //# 02: continued
+ typeParameters(superOfDouble, [#T]); // //# 02: continued
+ typeParameters(superOfString, [#T]); // //# 01: continued
typeArguments(superDecl, []);
typeArguments(superOfInt, [reflectClass(int)]);
- typeArguments(genericDecl, []); // /// 02: continued
- typeArguments(superOfR, [rFromGeneric]); // /// 02: continued
- typeArguments(genericOfDouble, [reflectClass(double)]); // /// 02: continued
- typeArguments(superOfDouble, [reflectClass(double)]); // /// 02: continued
- typeArguments(superOfString, [reflectClass(String)]); // /// 01: continued
+ typeArguments(genericDecl, []); // //# 02: continued
+ typeArguments(superOfR, [rFromGeneric]); // //# 02: continued
+ typeArguments(genericOfDouble, [reflectClass(double)]); // //# 02: continued
+ typeArguments(superOfDouble, [reflectClass(double)]); // //# 02: continued
+ typeArguments(superOfString, [reflectClass(String)]); // //# 01: continued
}

Powered by Google App Engine
This is Rietveld 408576698