Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: tests/compiler/dart2js/warnings_checker.dart

Issue 2765893003: Fix warnings_checker.dart handling of multitests (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/testing/lib/src/multitest.dart ('k') | tests/compiler/dart2js_extra/23486_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/warnings_checker.dart
diff --git a/tests/compiler/dart2js/warnings_checker.dart b/tests/compiler/dart2js/warnings_checker.dart
index fdbd12cba50e07bc42bcd48f88de616f364e2208..8e6d531aff6139c84bdc64239c772fe927b1ffcd 100644
--- a/tests/compiler/dart2js/warnings_checker.dart
+++ b/tests/compiler/dart2js/warnings_checker.dart
@@ -17,6 +17,8 @@ import 'package:compiler/src/source_file_provider.dart';
import 'package:compiler/src/util/uri_extras.dart';
import 'dart:convert';
+final _multiTestRegExpSeperator = new RegExp(r"//[#/]");
+
void checkWarnings(Map<String, dynamic> tests, [List<String> arguments]) {
bool isWindows = Platform.isWindows;
Uri script = currentDirectory.resolveUri(Platform.script);
@@ -30,7 +32,7 @@ void checkWarnings(Map<String, dynamic> tests, [List<String> arguments]) {
Map<int, String> expectedWarnings = {};
int lineNo = 0;
for (String line in source.split('\n')) {
- if (line.contains('///') &&
+ if (line.contains(_multiTestRegExpSeperator) &&
(line.contains('static type warning') ||
line.contains('static warning'))) {
expectedWarnings[lineNo] = line;
« no previous file with comments | « pkg/testing/lib/src/multitest.dart ('k') | tests/compiler/dart2js_extra/23486_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698