Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/rendering/RenderLayerScrollableArea.cpp

Issue 276583002: Fix const correctness of containerForRepaint (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fix LayoutRepainter Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 362 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 layer()->updateLayerPositionsAfterOverflowScroll(); 373 layer()->updateLayerPositionsAfterOverflowScroll();
374 // Update regions, scrolling may change the clip of a particular region. 374 // Update regions, scrolling may change the clip of a particular region.
375 frameView->updateAnnotatedRegions(); 375 frameView->updateAnnotatedRegions();
376 // FIXME: We shouldn't call updateWidgetPositions() here since it might tear down the render tree, 376 // FIXME: We shouldn't call updateWidgetPositions() here since it might tear down the render tree,
377 // for now we just crash to avoid allowing an attacker to use after free . 377 // for now we just crash to avoid allowing an attacker to use after free .
378 frameView->updateWidgetPositions(); 378 frameView->updateWidgetPositions();
379 RELEASE_ASSERT(frameView->renderView()); 379 RELEASE_ASSERT(frameView->renderView());
380 updateCompositingLayersAfterScroll(); 380 updateCompositingLayersAfterScroll();
381 } 381 }
382 382
383 RenderLayerModelObject* repaintContainer = box().containerForRepaint(); 383 const RenderLayerModelObject* repaintContainer = box().containerForRepaint() ;
384 // The caret rect needs to be invalidated after scrolling 384 // The caret rect needs to be invalidated after scrolling
385 frame->selection().setCaretRectNeedsUpdate(); 385 frame->selection().setCaretRectNeedsUpdate();
386 386
387 FloatQuad quadForFakeMouseMoveEvent; 387 FloatQuad quadForFakeMouseMoveEvent;
388 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled()) 388 if (RuntimeEnabledFeatures::repaintAfterLayoutEnabled())
389 quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previousRepai ntRect()); 389 quadForFakeMouseMoveEvent = FloatQuad(layer()->renderer()->previousRepai ntRect());
390 else 390 else
391 quadForFakeMouseMoveEvent = FloatQuad(layer()->repainter().repaintRect() ); 391 quadForFakeMouseMoveEvent = FloatQuad(layer()->repainter().repaintRect() );
392 392
393 quadForFakeMouseMoveEvent = repaintContainer->localToAbsoluteQuad(quadForFak eMouseMoveEvent); 393 quadForFakeMouseMoveEvent = repaintContainer->localToAbsoluteQuad(quadForFak eMouseMoveEvent);
(...skipping 1170 matching lines...) Expand 10 before | Expand all | Expand 10 after
1564 void RenderLayerScrollableArea::setForceNeedsCompositedScrolling(ForceNeedsCompo sitedScrollingMode mode) 1564 void RenderLayerScrollableArea::setForceNeedsCompositedScrolling(ForceNeedsCompo sitedScrollingMode mode)
1565 { 1565 {
1566 if (m_forceNeedsCompositedScrolling == mode) 1566 if (m_forceNeedsCompositedScrolling == mode)
1567 return; 1567 return;
1568 1568
1569 m_forceNeedsCompositedScrolling = mode; 1569 m_forceNeedsCompositedScrolling = mode;
1570 layer()->didUpdateNeedsCompositedScrolling(); 1570 layer()->didUpdateNeedsCompositedScrolling();
1571 } 1571 }
1572 1572
1573 } // Namespace WebCore 1573 } // Namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderLayerRepainter.cpp ('k') | Source/core/rendering/RenderObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698