Fix inline focus ring paint invalidation on continuation change

third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp

Index: third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
index 84fed48255919b79ec7288af193f569b377b34d7..945645ec4ac3f384fa0944468e359695351cb4ce 100644
--- a/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
@@ -50,29 +50,6 @@ void BlockFlowPaintInvalidator::invalidateDisplayItemClients(
       reason == PaintInvalidationSelection)
     return;
 
-  // If the block is a continuation or containing block of an inline
-  // continuation, invalidate the start object of the continuations if it has
-  // focus ring because change of continuation may change the shape of the focus
-  // ring.
-  if (m_blockFlow.isAnonymous()) {
-    LayoutObject* startOfContinuations = nullptr;
-    if (LayoutInline* inlineElementContinuation =
-            m_blockFlow.inlineElementContinuation()) {
-      // This block is an anonymous block continuation.
-      startOfContinuations = inlineElementContinuation->node()->layoutObject();
-    } else if (LayoutObject* firstChild = m_blockFlow.firstChild()) {
-      // This block is the anonymous containing block of an inline element
-      // continuation.
-      if (firstChild->isElementContinuation())
-        startOfContinuations = firstChild->node()->layoutObject();
-    }
-    if (startOfContinuations &&
-        startOfContinuations->styleRef().outlineStyleIsAuto())
-      ObjectPaintInvalidator(*startOfContinuations)
-          .slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(

[wkorman, 2017/03/21 19:31:52]

This change removes this display item client invalidation. Is that handled now
through the paint-offset-and-visual-rect bit processing logic?

[Xianzhu, 2017/03/22 02:46:07]

Yes. With setMayNeedPaintInvalidation(), we will update visual rect and
invalidate the whole object with outline.

-              *startOfContinuations, reason);
-  }
-
   RootInlineBox* line = m_blockFlow.firstRootBox();
   if (line && line->isFirstLineStyle()) {
     // It's the RootInlineBox that paints the ::first-line background. Note that