Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp

Issue 2765763002: Fix inline focus ring paint invalidation on continuation change (Closed)
Patch Set: - Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
diff --git a/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp b/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
index 84fed48255919b79ec7288af193f569b377b34d7..945645ec4ac3f384fa0944468e359695351cb4ce 100644
--- a/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
+++ b/third_party/WebKit/Source/core/paint/BlockFlowPaintInvalidator.cpp
@@ -50,29 +50,6 @@ void BlockFlowPaintInvalidator::invalidateDisplayItemClients(
reason == PaintInvalidationSelection)
return;
- // If the block is a continuation or containing block of an inline
- // continuation, invalidate the start object of the continuations if it has
- // focus ring because change of continuation may change the shape of the focus
- // ring.
- if (m_blockFlow.isAnonymous()) {
- LayoutObject* startOfContinuations = nullptr;
- if (LayoutInline* inlineElementContinuation =
- m_blockFlow.inlineElementContinuation()) {
- // This block is an anonymous block continuation.
- startOfContinuations = inlineElementContinuation->node()->layoutObject();
- } else if (LayoutObject* firstChild = m_blockFlow.firstChild()) {
- // This block is the anonymous containing block of an inline element
- // continuation.
- if (firstChild->isElementContinuation())
- startOfContinuations = firstChild->node()->layoutObject();
- }
- if (startOfContinuations &&
- startOfContinuations->styleRef().outlineStyleIsAuto())
- ObjectPaintInvalidator(*startOfContinuations)
- .slowSetPaintingLayerNeedsRepaintAndInvalidateDisplayItemClient(
- *startOfContinuations, reason);
- }
-
RootInlineBox* line = m_blockFlow.firstRootBox();
if (line && line->isFirstLineStyle()) {
// It's the RootInlineBox that paints the ::first-line background. Note that

Powered by Google App Engine
This is Rietveld 408576698