Source/platform/fonts/FontDescription.cpp - Issue 276573010: Adding Locale (language attribute) information to font and using the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/FontDescription.cpp

Issue 276573010: Adding Locale (language attribute) information to font and using the (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Comment fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/platform/fonts/FontDescription.h ('K') | « Source/platform/fonts/FontDescription.h ('k') | Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp » ('j') | Source/platform/fonts/harfbuzz/HarfBuzzShaper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/FontDescription.cpp

diff --git a/Source/platform/fonts/FontDescription.cpp b/Source/platform/fonts/FontDescription.cpp

index a55b93cc5366a24b99aa0caabafead3f87463022..4a545e13d7d63caea6f4fb44b66d833a4352363a 100644

--- a/Source/platform/fonts/FontDescription.cpp

+++ b/Source/platform/fonts/FontDescription.cpp

@@ -43,6 +43,7 @@ struct SameSizeAsFontDescription {

// FXIME: Make them fit into one word.

uint32_t bitfields;

uint32_t bitfields2 : 7;

+ hb_language_t locale;

Inactive 2014/05/22 13:52:02 Ditto, please move this up after the RefPtr.

};

COMPILE_ASSERT(sizeof(FontDescription) == sizeof(SameSizeAsFontDescription), FontDescription_should_stay_small);