Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: base/task_scheduler/scheduler_single_thread_task_runner_manager.cc

Issue 2765703002: Add the COM STA Task Runner (Closed)
Patch Set: CR Feedback Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
diff --git a/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc b/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
index 6a2676fb49b9e20bb8f06ea8b52a4839a76a8922..c566f54170f7cbf0acf6edc421cda063b51795e8 100644
--- a/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
+++ b/base/task_scheduler/scheduler_single_thread_task_runner_manager.cc
@@ -23,6 +23,12 @@
#include "base/threading/platform_thread.h"
#include "base/time/time.h"
+#if defined(OS_WIN)
+#include <windows.h>
+
+#include "base/win/scoped_com_initializer.h"
+#endif // defined(OS_WIN)
+
namespace base {
namespace internal {
@@ -129,6 +135,105 @@ class SchedulerWorkerDelegate : public SchedulerWorker::Delegate {
DISALLOW_COPY_AND_ASSIGN(SchedulerWorkerDelegate);
};
+#if defined(OS_WIN)
+
+class SchedulerWorkerCOMDelegate : public SchedulerWorkerDelegate {
+ public:
+ SchedulerWorkerCOMDelegate(const std::string& thread_name,
+ TaskTracker* task_tracker)
+ : SchedulerWorkerDelegate(thread_name), task_tracker_(task_tracker) {}
+
+ ~SchedulerWorkerCOMDelegate() override { DCHECK(!scoped_com_initializer_); }
+
+ // SchedulerWorker::Delegate:
+ void OnMainEntry(SchedulerWorker* worker) override {
+ SchedulerWorkerDelegate::OnMainEntry(worker);
+
+ scoped_com_initializer_ = MakeUnique<win::ScopedCOMInitializer>();
+ }
+
+ scoped_refptr<Sequence> GetWork(SchedulerWorker* worker) override {
+ // This scheme below allows us to cover the following scenarios:
+ // * Only SchedulerWorkerDelegate::GetWork() has work:
+ // Always return the sequence from GetWork().
+ // * Only the Windows Message Queue has work:
+ // Always return the sequence from GetWorkFromWindowsMessageQueue();
+ // * Both SchedulerWorkerDelegate::GetWork() and the Windows Message Queue
+ // have work:
+ // Process sequences from each source round-robin style.
+ scoped_refptr<Sequence> sequence;
+ if (get_work_first_) {
+ sequence = SchedulerWorkerDelegate::GetWork(worker);
+ if (sequence)
+ get_work_first_ = false;
+ }
+
+ if (!sequence) {
+ sequence = GetWorkFromWindowsMessageQueue();
+ if (sequence)
+ get_work_first_ = true;
+ }
+
+ if (!sequence && !get_work_first_) {
+ // This case is important if we checked the Windows Message Queue first
+ // and found there was no work. We don't want to return null immediately
+ // as that could cause the thread to go to sleep while work is waiting via
+ // SchedulerWorkerDelegate::GetWork().
+ sequence = SchedulerWorkerDelegate::GetWork(worker);
+ }
+ return sequence;
+ }
+
+ void OnMainExit() override { scoped_com_initializer_.reset(); }
+
+ void WaitForWork(WaitableEvent* wake_up_event) override {
+ DCHECK(wake_up_event);
+ const TimeDelta sleep_time = GetSleepTimeout();
+ const DWORD milliseconds_wait =
+ sleep_time.is_max() ? INFINITE : sleep_time.InMilliseconds();
+ HANDLE wake_up_event_handle = wake_up_event->handle();
+ DWORD result = MsgWaitForMultipleObjectsEx(
+ 1, &wake_up_event_handle, milliseconds_wait, QS_ALLINPUT, 0);
+ if (result == WAIT_OBJECT_0) {
+ // Reset the event since we woke up due to it.
+ wake_up_event->Reset();
+ }
+ }
+
+ private:
+ scoped_refptr<Sequence> GetWorkFromWindowsMessageQueue() {
+ MSG msg;
+ if (PeekMessage(&msg, nullptr, 0, 0, PM_REMOVE) != FALSE) {
+ auto pump_message_task =
+ MakeUnique<Task>(FROM_HERE,
+ base::Bind(
fdoray 2017/03/22 12:20:19 no base::
robliao 2017/03/22 17:56:52 Done.
+ [](MSG msg) {
+ TranslateMessage(&msg);
+ DispatchMessage(&msg);
+ },
+ std::move(msg)),
gab 2017/03/22 16:16:04 #include <utility>
robliao 2017/03/22 17:56:52 Done.
+ TaskTraits().MayBlock(), TimeDelta());
+ if (task_tracker_->WillPostTask(pump_message_task.get())) {
+ bool was_empty =
+ message_pump_sequence_->PushTask(std::move(pump_message_task));
+ DCHECK(was_empty) << "GetWorkFromWindowsMessageQueue() does not expect "
+ "queueing of pump tasks.";
+ return message_pump_sequence_;
+ }
+ }
+ return nullptr;
+ }
+
+ bool get_work_first_ = true;
+ const scoped_refptr<Sequence> message_pump_sequence_ = new Sequence;
+ TaskTracker* const task_tracker_;
+ std::unique_ptr<win::ScopedCOMInitializer> scoped_com_initializer_;
+
+ DISALLOW_COPY_AND_ASSIGN(SchedulerWorkerCOMDelegate);
+};
+
+#endif // defined(OS_WIN)
+
} // namespace
class SchedulerSingleThreadTaskRunnerManager::SchedulerSingleThreadTaskRunner
@@ -241,9 +346,23 @@ SchedulerSingleThreadTaskRunnerManager::CreateSingleThreadTaskRunnerWithTraits(
DCHECK_LT(index, worker_pool_params_vector_.size());
return new SchedulerSingleThreadTaskRunner(
this, traits,
- CreateAndRegisterSchedulerWorker(worker_pool_params_vector_[index]));
+ CreateAndRegisterSchedulerWorker(worker_pool_params_vector_[index],
+ DelegateType::DEFAULT));
}
+#if defined(OS_WIN)
+scoped_refptr<SingleThreadTaskRunner>
+SchedulerSingleThreadTaskRunnerManager::CreateCOMSTATaskRunnerWithTraits(
+ const TaskTraits& traits) {
+ size_t index = worker_pool_index_for_traits_callback_.Run(traits);
+ DCHECK_LT(index, worker_pool_params_vector_.size());
+ return new SchedulerSingleThreadTaskRunner(
+ this, traits,
+ CreateAndRegisterSchedulerWorker(worker_pool_params_vector_[index],
+ DelegateType::COM_STA));
+}
+#endif // defined(OS_WIN)
+
void SchedulerSingleThreadTaskRunnerManager::JoinForTesting() {
decltype(workers_) local_workers;
{
@@ -264,11 +383,27 @@ void SchedulerSingleThreadTaskRunnerManager::JoinForTesting() {
SchedulerWorker*
SchedulerSingleThreadTaskRunnerManager::CreateAndRegisterSchedulerWorker(
- const SchedulerWorkerPoolParams& params) {
+ const SchedulerWorkerPoolParams& params,
+ DelegateType delegate_type) {
AutoSchedulerLock auto_lock(workers_lock_);
int id = next_worker_id_++;
- auto delegate = MakeUnique<SchedulerWorkerDelegate>(base::StringPrintf(
- "TaskSchedulerSingleThreadWorker%d%s", id, params.name().c_str()));
+
+ std::unique_ptr<SchedulerWorkerDelegate> delegate;
+ switch (delegate_type) {
+ case DelegateType::DEFAULT:
+ delegate = MakeUnique<SchedulerWorkerDelegate>(base::StringPrintf(
fdoray 2017/03/22 12:20:19 no base::
robliao 2017/03/22 17:56:52 Done.
+ "TaskSchedulerSingleThreadWorker%d%s", id, params.name().c_str()));
+ break;
+#if defined(OS_WIN)
+ case DelegateType::COM_STA:
+ delegate = MakeUnique<SchedulerWorkerCOMDelegate>(
+ base::StringPrintf("TaskSchedulerSingleThreadWorker%d%sCOMSTA", id,
fdoray 2017/03/22 12:20:19 no base::
robliao 2017/03/22 17:56:52 Done.
+ params.name().c_str()),
+ task_tracker_);
+ break;
+#endif
+ }
+
workers_.emplace_back(SchedulerWorker::Create(
params.priority_hint(), std::move(delegate), task_tracker_,
SchedulerWorker::InitialState::DETACHED));

Powered by Google App Engine
This is Rietveld 408576698