Update all tests

Update all tests


Support //# multitests for better dartfmt compatibility and fewer multitest false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/ /$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Committed: https://github.com/dart-lang/sdk/commit/3c7353d9877173fa290b8f5e5b4a9aa231ee5111

[Jacob, 2017-03-21 00:33:38]

jacobr@google.com changed reviewers:
+ efortuna@google.com

[Jacob, 2017-03-21 00:35:12]

Description was changed from

==========
Update all tests


Support //# multitests for better dartfmt compatibility and fewer multitest
false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/
/$1\/\/# /'

BUG=
==========

to

==========
Update all tests


Support //# multitests for better dartfmt compatibility and fewer multitest
false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/
/$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.
==========

[Emily Fortuna, 2017-03-21 00:49:06]

lgtm

https://codereview.chromium.org/2765693002/diff/1/pkg/dev_compiler/test/multi...
File pkg/dev_compiler/test/multitest.dart (right):

https://codereview.chromium.org/2765693002/diff/1/pkg/dev_compiler/test/multi...
pkg/dev_compiler/test/multitest.dart:19: // Handle both //# and the legacy ///
multitest regexp patterns.
Are you going to have a followup CL where you remove support for the ///? doing
so would be a sure way to ensure that this is working as intended now.

https://codereview.chromium.org/2765693002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/23486_test.dart (right):

https://codereview.chromium.org/2765693002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/23486_test.dart:34: Expect.throws(new A().m);      
   //# 01: continued
Are you going to also adjust the whitespace in these so they line up: 
//#         01: continued
    //#     02: continued
  //#       03: compiled-time error

?

I thought that was what we discussed

[Jacob, 2017-03-21 00:58:19]

I'll send a followup CL removing //

https://codereview.chromium.org/2765693002/diff/1/tests/compiler/dart2js_extr...
File tests/compiler/dart2js_extra/23486_test.dart (right):

https://codereview.chromium.org/2765693002/diff/1/tests/compiler/dart2js_extr...
tests/compiler/dart2js_extra/23486_test.dart:34: Expect.throws(new A().m);      
   //# 01: continued
On 2017/03/21 00:49:05, Emily Fortuna wrote:
> Are you going to also adjust the whitespace in these so they line up: 
> //#         01: continued
>     //#     02: continued
>   //#       03: compiled-time error
> 
> ?
> 
> I thought that was what we discussed

A separate even more awesome CL is fixing all the whitespace.

[Jacob, 2017-03-21 19:39:33]

Description was changed from

==========
Update all tests


Support //# multitests for better dartfmt compatibility and fewer multitest
false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/
/$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.
==========

to

==========
Update all tests


Support //# multitests for better dartfmt compatibility and fewer multitest
false positives

All files under tests were manually updated with

find . -iregex '.*\.dart$' -print0 | xargs -0 perl -pi -e 's/(\S\s+)\/\/\/
/$1\/\/# /'

For now both old and new styles are allowed to accommodate CO19 tests.

R=efortuna@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3c7353d9877173fa290b8f5e5b4a9aa231ee5111
==========

[Jacob, 2017-03-21 19:39:36]

Committed patchset #1 (id:1) manually as
3c7353d9877173fa290b8f5e5b4a9aa231ee5111 (presubmit successful).