Add Internal Tasks to the Task Scheduler

Add Internal Tasks to the Task Scheduler

The Task Scheduler will start generating internal tasks with COM.
These shouldn't be logged or tracked against actual work, so the task
tracker handles these separately from normal tasks.

Reference Changelist:
https://codereview.chromium.org/2762703002

BUG=662122

[robliao, 2017-03-20 20:32:36]

robliao@chromium.org changed reviewers:
+ fdoray@chromium.org, gab@chromium.org

[gab, 2017-03-20 20:38:23]

Hmmm, need to think about this some more, sounds scary to hide tasks from
tracing and other tools, what kind of internal tasks did you have in mind?

https://codereview.chromium.org/2765573003/diff/1/base/task_scheduler/task_tr...
File base/task_scheduler/task_tracker.cc (right):

https://codereview.chromium.org/2765573003/diff/1/base/task_scheduler/task_tr...
base/task_scheduler/task_tracker.cc:288: // until
wrap

[robliao, 2017-03-20 21:07:42]

Description was changed from

==========
Add Internal Tasks to the Task Scheduler

The Task Scheduler will start generating internal tasks with COM.
These shouldn't be logged or tracked against actual work, so the task
tracker handles these separately from normal tasks.

BUG=662122
==========

to

==========
Add Internal Tasks to the Task Scheduler

The Task Scheduler will start generating internal tasks with COM.
These shouldn't be logged or tracked against actual work, so the task
tracker handles these separately from normal tasks.

Reference Changelist:
https://codereview.chromium.org/2762703002

BUG=662122
==========

[robliao, 2017-03-20 21:17:15]

> Hmmm, need to think about this some more, sounds scary to hide tasks from
tracing and other tools, what kind of internal tasks did you have in mind?

The way we're going to pump messages for COM is to post a task that pumps a
single message. These weren't created by the user, so it could be unexpected to
show them in tracing.

At the same time, I can see an argument for this for COM callbacks. Maybe we
should report but track them slightly differently?

https://codereview.chromium.org/2765573003/diff/1/base/task_scheduler/task_tr...
File base/task_scheduler/task_tracker.cc (right):

https://codereview.chromium.org/2765573003/diff/1/base/task_scheduler/task_tr...
base/task_scheduler/task_tracker.cc:288: // until
On 2017/03/20 20:38:23, gab wrote:
> wrap

Done.

[chromium-reviews, 2017-03-20 21:33:18]

If they're not a big deal then it won't matter, if they're a big deal, then
we want to know, so... I could see an argument for special FROM_HERE
plumbing but don't think we should hide. We can hide later if it's really a
nuisance in a given tool but not off the bat.

Le lun. 20 mars 2017 17:17, <robliao@chromium.org> a écrit :

> > Hmmm, need to think about this some more, sounds scary to hide tasks from
> tracing and other tools, what kind of internal tasks did you have in mind?
>
> The way we're going to pump messages for COM is to post a task that pumps a
> single message. These weren't created by the user, so it could be
> unexpected to
> show them in tracing.
>
> At the same time, I can see an argument for this for COM callbacks. Maybe
> we
> should report but track them slightly differently?
>
>
>
>
>
https://codereview.chromium.org/2765573003/diff/1/base/task_scheduler/task_tr...
> File base/task_scheduler/task_tracker.cc (right):
>
>
>
https://codereview.chromium.org/2765573003/diff/1/base/task_scheduler/task_tr...
> base/task_scheduler/task_tracker.cc:288: // until
> On 2017/03/20 20:38:23, gab wrote:
> > wrap
>
> Done.
>
> https://codereview.chromium.org/2765573003/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[robliao, 2017-03-20 21:40:22]

Sounds good. I'll skip the hiding portion and we'll post tasks as are.

On Mon, Mar 20, 2017 at 2:33 PM, Gabriel Charette <gab@google.com> wrote:

> If they're not a big deal then it won't matter, if they're a big deal,
> then we want to know, so... I could see an argument for special FROM_HERE
> plumbing but don't think we should hide. We can hide later if it's really a
> nuisance in a given tool but not off the bat.
>
> Le lun. 20 mars 2017 17:17, <robliao@chromium.org> a écrit :
>
>> > Hmmm, need to think about this some more, sounds scary to hide tasks
>> from
>> tracing and other tools, what kind of internal tasks did you have in mind?
>>
>> The way we're going to pump messages for COM is to post a task that pumps
>> a
>> single message. These weren't created by the user, so it could be
>> unexpected to
>> show them in tracing.
>>
>> At the same time, I can see an argument for this for COM callbacks. Maybe
>> we
>> should report but track them slightly differently?
>>
>>
>>
>> https://codereview.chromium.org/2765573003/diff/1/base/
>> task_scheduler/task_tracker.cc
>> File base/task_scheduler/task_tracker.cc (right):
>>
>> https://codereview.chromium.org/2765573003/diff/1/base/
>> task_scheduler/task_tracker.cc#newcode288
>> base/task_scheduler/task_tracker.cc:288: // until
>> On 2017/03/20 20:38:23, gab wrote:
>> > wrap
>>
>> Done.
>>
>> https://codereview.chromium.org/2765573003/
>>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[robliao, 2017-03-21 23:09:22]

On 2017/03/20 21:40:22, robliao wrote:
> Sounds good. I'll skip the hiding portion and we'll post tasks as are.
> 
> On Mon, Mar 20, 2017 at 2:33 PM, Gabriel Charette <mailto:gab@google.com>
wrote:
> 
> > If they're not a big deal then it won't matter, if they're a big deal,
> > then we want to know, so... I could see an argument for special FROM_HERE
> > plumbing but don't think we should hide. We can hide later if it's really a
> > nuisance in a given tool but not off the bat.
> >
> > Le lun. 20 mars 2017 17:17, <mailto:robliao@chromium.org> a écrit :
> >
> >> > Hmmm, need to think about this some more, sounds scary to hide tasks
> >> from
> >> tracing and other tools, what kind of internal tasks did you have in mind?
> >>
> >> The way we're going to pump messages for COM is to post a task that pumps
> >> a
> >> single message. These weren't created by the user, so it could be
> >> unexpected to
> >> show them in tracing.
> >>
> >> At the same time, I can see an argument for this for COM callbacks. Maybe
> >> we
> >> should report but track them slightly differently?
> >>
> >>
> >>
> >> https://codereview.chromium.org/2765573003/diff/1/base/
> >> task_scheduler/task_tracker.cc
> >> File base/task_scheduler/task_tracker.cc (right):
> >>
> >> https://codereview.chromium.org/2765573003/diff/1/base/
> >> task_scheduler/task_tracker.cc#newcode288
> >> base/task_scheduler/task_tracker.cc:288: // until
> >> On 2017/03/20 20:38:23, gab wrote:
> >> > wrap
> >>
> >> Done.
> >>
> >> https://codereview.chromium.org/2765573003/
> >>
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

Closing this for now. We can add this in if the internal tasks turn out to cause
tracing issues.