Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 276553002: Make content_extractor support a multiple-url request (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make content_extractor support a multiple-url request This adds the --urls flag which accepts a space-separated list of urls to distill. This adds a pretty straightforward approach to having multiple of these requests happening at the same time. Once all requests are finished, they will be printed (in the order that they appeared in --urls). If printing binary, each serialized protobuf will be preceded by its size (as a varint32). TBR=ben@ Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276819

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -34 lines) Patch
M components/dom_distiller/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor.cc View 1 9 chunks +113 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cjhopman
6 years, 7 months ago (2014-05-13 16:45:37 UTC) #1
Yaron
lgtm https://codereview.chromium.org/276553002/diff/1/components/dom_distiller/standalone/content_extractor.cc File components/dom_distiller/standalone/content_extractor.cc (right): https://codereview.chromium.org/276553002/diff/1/components/dom_distiller/standalone/content_extractor.cc#newcode150 components/dom_distiller/standalone/content_extractor.cc:150: ADD_FAILURE() << "Bad url"; << i << ": ...
6 years, 7 months ago (2014-05-13 18:14:30 UTC) #2
cjhopman
TBR ben@ for adding google/ to DEPS
6 years, 6 months ago (2014-06-12 17:38:43 UTC) #3
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 6 months ago (2014-06-12 17:38:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/276553002/30001
6 years, 6 months ago (2014-06-12 17:40:57 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 22:02:33 UTC) #6
Message was sent while issue was closed.
Change committed as 276819

Powered by Google App Engine
This is Rietveld 408576698