Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 2765523003: The formatter struggles a bit with these files. (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org, Bob Nystrom
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : The formatter struggles a bit with these files. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+779 lines, -735 lines) Patch
M runtime/bin/vmservice/loader.dart View 1 36 chunks +258 lines, -264 lines 0 comments Download
M runtime/lib/convert_patch.dart View 1 27 chunks +171 lines, -137 lines 0 comments Download
M runtime/lib/integers.dart View 1 16 chunks +131 lines, -78 lines 0 comments Download
M runtime/lib/integers_patch.dart View 1 6 chunks +47 lines, -49 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 52 chunks +164 lines, -199 lines 0 comments Download
M runtime/tests/vm/dart/data_uri_import_test.dart View 1 1 chunk +8 lines, -8 lines 1 comment Download

Messages

Total messages: 6 (3 generated)
Jacob
The formatter struggles a bit with these files. I made small tweaks to the source ...
3 years, 9 months ago (2017-03-20 20:52:34 UTC) #2
Cutch
lgtm except the one test https://codereview.chromium.org/2765523003/diff/20001/runtime/tests/vm/dart/data_uri_import_test.dart File runtime/tests/vm/dart/data_uri_import_test.dart (right): https://codereview.chromium.org/2765523003/diff/20001/runtime/tests/vm/dart/data_uri_import_test.dart#newcode6 runtime/tests/vm/dart/data_uri_import_test.dart:6: import 'data:application/dart;charset=utf-8,foo%28%29%20%3D%3E%2042%3B'; // percentencoded: ...
3 years, 9 months ago (2017-03-20 23:02:33 UTC) #4
Jacob
3 years, 9 months ago (2017-03-22 01:00:58 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
a129931cdad451f176b1e8eb7fbc17a5767d8570 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698