third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp - Issue 2765503003: Fix position:sticky location bug when scroller is not a stacking context

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

Issue 2765503003: Fix position:sticky location bug when scroller is not a stacking context (Closed)

Patch Set: Add unittest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/compositing/overflow/composited-sticky-element-stacking-context-expected.html ('k') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

index c715a2954ec4c2eafbe10594703a5a5c310ac30e..d183975688e2d450bfc891d82813d4f57cf1e628 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp

@@ -319,7 +319,7 @@ void CompositedLayerMapping::updateStickyConstraints(

LayoutPoint enclosingLayerOffset;

compositingContainer->convertToLayerCoords(ancestorOverflowLayer,

enclosingLayerOffset);

- if (compositingContainer != ancestorOverflowLayer) {

+ if (!scrollParent() && compositingContainer != ancestorOverflowLayer) {

flackr 2017/03/23 16:58:03 It's probably worth "documenting" why we do this w

smcgruer 2017/03/23 17:22:48 Done.

enclosingLayerOffset += LayoutSize(

ancestorOverflowLayer->getScrollableArea()->getScrollOffset());

}