Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

Issue 2765493002: Fixing accessibility bug with extensions preferences (Closed)
Patch Set: Fixed unit tests for aria-hidden and fixed accessibility of extension-options-overlay-icon Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
index 1aca91b8c5da4bd2ea5e2c856167b8d1cc81060e..3bf00fe3c22928c7a9dd6f2cc17e8a29af5bda0b 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
+++ b/chrome/browser/ui/webui/extensions/extension_settings_browsertest.js
@@ -406,6 +406,8 @@ TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'testChromeSendHandler',
// Just navigating to the page should trigger the chrome.send().
var assertOverlayVisible = function() {
assertTrue($('extension-commands-overlay').classList.contains('showing'));
+ assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
+ 'false');
this.nextStep();
};
@@ -417,6 +419,8 @@ TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'extensionSettingsUri',
function() {
var closeCommandOverlay = function() {
assertTrue($('extension-commands-overlay').classList.contains('showing'));
+ assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
+ 'false');
assertEquals(window.location.href,
'chrome://extensions-frame/configureCommands');
@@ -424,6 +428,8 @@ TEST_F('SettingsCommandsExtensionSettingsWebUITest', 'extensionSettingsUri',
$('extension-commands-dismiss').click();
assertFalse($('extension-commands-overlay').classList.contains('showing'));
+ assertEquals($('extension-commands-overlay').getAttribute('aria-hidden'),
+ 'true');
this.nextStep();
};

Powered by Google App Engine
This is Rietveld 408576698