chrome/browser/resources/extensions/extension_options_overlay.html - Issue 2765493002: Fixing accessibility bug with extensions preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extension_options_overlay.html

Issue 2765493002: Fixing accessibility bug with extensions preferences (Closed)

Patch Set: Fixed unit tests for aria-hidden and fixed accessibility of extension-options-overlay-icon Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/extension_options_overlay.html

diff --git a/chrome/browser/resources/extensions/extension_options_overlay.html b/chrome/browser/resources/extensions/extension_options_overlay.html

index 6f2c9177f3f76ac4fcfa65aafbe4054d60497fc2..2398ac35be6dce8f71bed3a6a91201c7ee927cdf 100644

--- a/chrome/browser/resources/extensions/extension_options_overlay.html

+++ b/chrome/browser/resources/extensions/extension_options_overlay.html

@@ -6,7 +6,8 @@ in the LICENSE file.

- <img id="extension-options-overlay-icon"></img>

+ <img id="extension-options-overlay-icon"

+ aria-hidden="true"></img>

Finnur 2017/03/24 14:25:42 I don't know... I'm a little uncomfortable with th

</div>

« no previous file with comments | « AUTHORS ('k') | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »