chrome/browser/resources/extensions/extensions.js - Issue 2765493002: Fixing accessibility bug with extensions preferences

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/extensions/extensions.js

Issue 2765493002: Fixing accessibility bug with extensions preferences (Closed)

Patch Set: Reverted back to aria-hidden version. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/extensions/extensions.js

diff --git a/chrome/browser/resources/extensions/extensions.js b/chrome/browser/resources/extensions/extensions.js

index d792412d2ab025b9a4e880be3ea420f22710e9a4..fb146e6653cfd73314e633633dc42ff102f9a55a 100644

--- a/chrome/browser/resources/extensions/extensions.js

+++ b/chrome/browser/resources/extensions/extensions.js

@@ -392,7 +392,8 @@ cr.define('extensions', function() {

var pages = document.querySelectorAll('.page');

for (var i = 0; i < pages.length; i++) {

- pages[i].setAttribute('aria-hidden', node ? 'true' : 'false');

+ var hidden = (node != pages[i]) ? 'true' : 'false';

+ pages[i].setAttribute('aria-hidden', hidden);

}

$('overlay').hidden = !node;