Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2765443005: [Devtools] Fixed network indicator icon for throttling (Closed)
Patch Set: added tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
index 79922acaeba41c74c460120c1a117114d0be3507..d7b9ae832ddc9a39630308fb20a686c5be5709fa 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
@@ -110,30 +110,6 @@ Network.NetworkPanel = class extends UI.Panel {
this._networkLogView.addEventListener(Network.NetworkLogView.Events.UpdateRequest, this._onUpdateRequest, this);
Components.DataSaverInfobar.maybeShowInPanel(this);
-
- var blockedURLsSetting = Common.moduleSetting('networkBlockedURLs');
- blockedURLsSetting.addChangeListener(updateIconVisibility.bind(this));
- var requestBlockingEnabledSetting = Common.moduleSetting('requestBlockingEnabled');
- requestBlockingEnabledSetting.addChangeListener(updateIconVisibility.bind(this));
- SDK.multitargetNetworkManager.addEventListener(
- SDK.MultitargetNetworkManager.Events.ConditionsChanged, updateIconVisibility.bind(this));
-
- updateIconVisibility.call(this);
-
- /**
- * @this {Network.NetworkPanel}
- */
- function updateIconVisibility() {
- var icon = null;
- if (SDK.multitargetNetworkManager.isThrottling()) {
- icon = UI.Icon.create('smallicon-warning');
- icon.title = Common.UIString('Network throttling is enabled');
- } else if (requestBlockingEnabledSetting.get() && blockedURLsSetting.get().length) {
- icon = UI.Icon.create('smallicon-warning');
- icon.title = Common.UIString('Requests may be blocked');
- }
- UI.inspectorView.setPanelIcon(this.name, icon);
- }
}
/**
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/main/Main.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698