media/mojo/interfaces/android_overlay.mojom - Issue 2765443004: AndroidOverlay implementation using Dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/mojo/interfaces/android_overlay.mojom

Issue 2765443004: AndroidOverlay implementation using Dialog. (Closed)

Patch Set: cl feedback, except surface_tracker refactor Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/javatests/src/org/chromium/content/browser/androidoverlay/DialogOverlayImplTest.java ('K') | « media/mojo/clients/mojo_android_overlay_unittest.cc ('k') | ui/android/java/src/org/chromium/ui/base/WindowAndroid.java » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 module media.mojom;	5 module media.mojom;

6	6

7 import "media/mojo/interfaces/media_types.mojom";	7 import "media/mojo/interfaces/media_types.mojom";

8 import "mojo/common/unguessable_token.mojom";	8 import "mojo/common/unguessable_token.mojom";

9 import "ui/gfx/geometry/mojo/geometry.mojom";	9 import "ui/gfx/geometry/mojo/geometry.mojom";

10	10

(...skipping 39 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
50 // \|routing_token\| provides the client with an opaque handle that will attach	50 // \|routing_token\| provides the client with an opaque handle that will attach

51 // an overlay to a the correct WindowAndroid. Typical usage is that a	51 // an overlay to a the correct WindowAndroid. Typical usage is that a

52 // RenderFrameHostImpl will provide this token to the RenderFrame. When the	52 // RenderFrameHostImpl will provide this token to the RenderFrame. When the

53 // overlay is created, the WindowAndroid that currently hosts the render frame	53 // overlay is created, the WindowAndroid that currently hosts the render frame

54 // will be the parent of the overlay. For legacy reasons, we need this token	54 // will be the parent of the overlay. For legacy reasons, we need this token

55 // to be sent via IPC, so using the message pipe, or other mojo construct, as	55 // to be sent via IPC, so using the message pipe, or other mojo construct, as

56 // the identifier won't work yet.	56 // the identifier won't work yet.

57 mojo.common.mojom.UnguessableToken routing_token;	57 mojo.common.mojom.UnguessableToken routing_token;

58	58

59 gfx.mojom.Rect rect;	59 gfx.mojom.Rect rect;

	60 bool secure;
	dcheng 2017/04/03 19:12:40 I'm not sure what \|secure\| means here. I'm not sure what \|secure\| means here. liberato (no reviews please) 2017/04/04 17:49:29 secure surface, as in protected content. i've add Show quoted text On 2017/04/03 19:12:40, dcheng wrote: > I'm not sure what \|secure\| means here. secure surface, as in protected content. i've added a comment.
60 };	61 };

OLD	NEW