content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java - Issue 2765443004: AndroidOverlay implementation using Dialog.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/public/android/java/src/org/chromium/content_public/browser/RenderFrameHost.java

Issue 2765443004: AndroidOverlay implementation using Dialog. (Closed)

Patch Set: fixed gn Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/public/android/java/src/org/chromium/content/browser/androidoverlay/DialogOverlayOperationsImpl.java ('K') | « content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java ('k') | content/public/android/javatests/src/org/chromium/content/browser/androidoverlay/DialogOverlayImplTest.java » ('j') | content/public/browser/render_frame_host.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2017 The Chromium Authors. All rights reserved.	1 // Copyright 2017 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 package org.chromium.content_public.browser;	5 package org.chromium.content_public.browser;

6	6

	7 import org.chromium.base.UnguessableToken;

	8

7 /**	9 /**

8 * The RenderFrameHost Java wrapper to allow communicating with the native Rende rFrameHost object.	10 * The RenderFrameHost Java wrapper to allow communicating with the native Rende rFrameHost object.

9 *	11 *

10 */	12 */

11 public interface RenderFrameHost {	13 public interface RenderFrameHost {

12 /**	14 /**

13 * Get the last committed URL of the frame.	15 * Get the last committed URL of the frame.

14 *	16 *

15 * @return The last committed URL of the frame.	17 * @return The last committed URL of the frame.

16 */	18 */

17 String getLastCommittedURL();	19 String getLastCommittedURL();

	20

	21 /**

	22 * Return the AndroidOverlay routing token for this RenderFrameHost.

	23 */

	24 UnguessableToken getAndroidOverlayRoutingToken();
	boliu 2017/03/30 22:42:02 doesn't need to be in content_public if nothing ou doesn't need to be in content_public if nothing outside of content needs this liberato (no reviews please) 2017/04/04 17:49:28 good point, done. Show quoted text On 2017/03/30 22:42:02, boliu wrote: > doesn't need to be in content_public if nothing outside of content needs this good point, done.
18 }	25 }

OLD	NEW