Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: milo/common/config/settings.proto

Issue 2765383002: Milo: Move instance configuration to luci-config (Closed)
Patch Set: Review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/swarming/html.go ('k') | milo/common/config/settings.pb.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/common/config/settings.proto
diff --git a/milo/common/config/settings.proto b/milo/common/config/settings.proto
index a843a49cdf535a08912701f168ef17ce02f3a956..e98375695a5ae22c7ac087a7efdbe1e3446d4a86 100644
--- a/milo/common/config/settings.proto
+++ b/milo/common/config/settings.proto
@@ -7,11 +7,40 @@ syntax = "proto3";
package config;
// Settings represents the format for the global (service) config for Milo.
-message Settings{
- message Buildbot{
+message Settings {
+ message Buildbot {
// internal_reader is the infra-auth group that is allowed to read internal
// buildbot data.
string internal_reader = 1;
+
+ // public_topic is the name of the pubsub topic where public builds come in
+ // from
+ string public_topic = 2;
+
+ // internal_topic is the name of the pubsub topic where internal builds
+ // come in from
+ string internal_topic = 3;
}
Buildbot buildbot = 1;
+
+ message Buildbucket {
+ // name is the user friendly name of the Buildbucket instance we're pointing to.
+ string name = 1;
+
+ // host is the hostname of the buildbucket instance we're pointing to (sans schema).
+ string host = 2;
+ }
+ Buildbucket buildbucket = 2;
+
+ message Swarming {
+ // default_host is the hostname of the swarming host Milo defaults to, if
+ // none is specified. Default host is implicitly an allowed host.
+ string default_host = 1;
+
+ // allowed_hosts is a whitelist of hostnames of swarming instances
+ // that Milo is allowed to talk to. This is specified here for security
+ // reasons, because Milo will hand out its oauth2 token to a swarming host.
+ repeated string allowed_hosts = 2;
+ }
+ Swarming swarming = 3;
}
« no previous file with comments | « milo/appengine/swarming/html.go ('k') | milo/common/config/settings.pb.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698