Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: milo/appengine/buildbot/build.go

Issue 2765383002: Milo: Move instance configuration to luci-config (Closed)
Patch Set: Review Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | milo/appengine/buildbot/build_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/build.go
diff --git a/milo/appengine/buildbot/build.go b/milo/appengine/buildbot/build.go
index 138ee35da6629f1163ada399c972d5dcb945f5c4..463bede48608eb7e3e62e6020b3d41897332a517 100644
--- a/milo/appengine/buildbot/build.go
+++ b/milo/appengine/buildbot/build.go
@@ -114,7 +114,7 @@ func getBanner(c context.Context, b *buildbotBuild) *resp.LogoBanner {
return nil
}
-// summary Extract the top level summary from a buildbot build as a
+// summary extracts the top level summary from a buildbot build as a
// BuildComponent
func summary(c context.Context, b *buildbotBuild) resp.BuildComponent {
// TODO(hinoka): use b.toStatus()
@@ -144,7 +144,6 @@ func summary(c context.Context, b *buildbotBuild) resp.BuildComponent {
}
source := &resp.Link{
Label: fmt.Sprintf("%s/%s/%d", b.Master, b.Buildername, b.Number),
- // TODO(hinoka): Internal builds.
URL: fmt.Sprintf(
"https://%s/%s/builders/%s/builds/%d",
host, b.Master, b.Buildername, b.Number),
« no previous file with comments | « no previous file | milo/appengine/buildbot/build_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698