Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: chrome/browser/chromeos/file_manager/file_browser_handlers.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)
Patch Set: Fix comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/file_manager/file_browser_handlers.cc
diff --git a/chrome/browser/chromeos/file_manager/file_browser_handlers.cc b/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
index 7ed9f3493f5a035322cf99df00941c27b96ddd7b..a39ac8e3b7a41338b9d5c15718953467ad595c15 100644
--- a/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
+++ b/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
@@ -392,8 +392,8 @@ void FileBrowserHandlerExecutor::SetupPermissionsAndDispatchEvent(
auto details = base::MakeUnique<base::DictionaryValue>();
// Get file definitions. These will be replaced with Entry instances by
// dispatchEvent() method from event_binding.js.
- base::ListValue* file_entries = new base::ListValue();
- details->Set("entries", file_entries);
+ auto file_entries = base::MakeUnique<base::ListValue>();
+ details->Set("entries", std::move(file_entries));
event_args->Append(std::move(details));
for (EntryDefinitionList::const_iterator iter =

Powered by Google App Engine
This is Rietveld 408576698