Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)
Patch Set: Fix comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/screens/user_selection_screen.cc
diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.cc b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
index cb42359020fa1f829e70b4f1f3059921e98746e0..33d6629f9d8cd6bb371ddf098375139e71781939 100644
--- a/chrome/browser/chromeos/login/screens/user_selection_screen.cc
+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.cc
@@ -99,7 +99,7 @@ void AddPublicSessionDetailsToUserDictionaryEntry(
g_browser_process->GetApplicationLocale());
// Set |kKeyInitialLocales| to the list of available locales.
- user_dict->Set(kKeyInitialLocales, available_locales.release());
+ user_dict->Set(kKeyInitialLocales, std::move(available_locales));
// Set |kKeyInitialLocale| to the initially selected locale.
user_dict->SetString(kKeyInitialLocale, selected_locale);
@@ -115,8 +115,7 @@ void AddPublicSessionDetailsToUserDictionaryEntry(
// Set |kKeyInitialKeyboardLayout| to the current keyboard layout. This
// value will be used temporarily only because the UI immediately requests a
// list of keyboard layouts suitable for the currently selected locale.
- user_dict->Set(kKeyInitialKeyboardLayout,
- GetCurrentKeyboardLayout().release());
+ user_dict->Set(kKeyInitialKeyboardLayout, GetCurrentKeyboardLayout());
}
// Returns true if the PIN keyboard should be displayed for the given |user|.
« no previous file with comments | « chrome/browser/chromeos/login/helper.cc ('k') | chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698