chrome/browser/chromeos/extensions/accessibility_features_apitest.cc - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/display/display_preferences_unittest.cc ('k') | chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

diff --git a/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc b/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

index 02416528e1e751f0fd4a485cd3dfb65a0491c868..d9a587111881c3bbdf3f11355d6b172d099761be 100644

--- a/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

+++ b/chrome/browser/chromeos/extensions/accessibility_features_apitest.cc

@@ -152,12 +152,12 @@ class AccessibilityFeaturesApiTest : public ExtensionApiTest,

std::unique_ptr<base::ListValue> enabled_list(new base::ListValue);

for (size_t i = 0; i < enabled_features.size(); ++i)

enabled_list->AppendString(enabled_features[i]);

- test_arg.Set(kEnabledFeaturesKey, enabled_list.release());

+ test_arg.Set(kEnabledFeaturesKey, std::move(enabled_list));

std::unique_ptr<base::ListValue> disabled_list(new base::ListValue);

for (size_t i = 0; i < disabled_features.size(); ++i)

disabled_list->AppendString(disabled_features[i]);

- test_arg.Set(kDisabledFeaturesKey, disabled_list.release());

+ test_arg.Set(kDisabledFeaturesKey, std::move(disabled_list));

return base::JSONWriter::Write(test_arg, result);

}