chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc - Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

Issue 2765363004: Stop passing raw pointers to DictionaryValue::Set, part 2 (Closed)

Patch Set: Fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

diff --git a/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc b/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

index 05c9c4564752e8823da8c775e055761e1ce97ac9..dafab9a65d9319f0ce724834fb68e5de7923a063 100644

--- a/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

+++ b/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc

@@ -325,7 +325,7 @@ class KioskAppManagerTest : public InProcessBrowserTest {

PrefService* local_state = g_browser_process->local_state();

DictionaryPrefUpdate dict_update(local_state,

KioskAppManager::kKioskDictionaryName);

- dict_update->Set(KioskAppManager::kKeyApps, apps_dict.release());

+ dict_update->Set(KioskAppManager::kKeyApps, std::move(apps_dict));

// Make the app appear in device settings.

base::ListValue device_local_accounts;